Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency babel-eslint to ^10.0.3 #44029

Merged
merged 1 commit into from
Aug 27, 2019
Merged

Update dependency babel-eslint to ^10.0.3 #44029

merged 1 commit into from
Aug 27, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 26, 2019

This PR contains the following updates:

Package Type Update Change
babel-eslint peerDependencies patch ^10.0.2 -> ^10.0.3
babel-eslint devDependencies patch ^10.0.2 -> ^10.0.3

Release Notes

babel/babel-eslint

v10.0.3

Compare Source

Fixes #​791, also eslint/eslint#​12117

Some context: #​793 (comment)

We ended up going with @​JLHwung's PR #​794 which uses ESLint's deps instead of going with peerDeps since it really depends on the version being used and we don't want users to have to install it directly on their own.

babel-eslint is patching patches of the dependencies of ESLint itself so these kinds of issues have happened in the past. We'll need to look into figuring out how to have a more solid way of modifying behavior instead of this monkeypatching type of thing for future releases.


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@renovate renovate bot added release_note:skip Skip the PR/issue when compiling release notes renovate Renovate dependency update with major version updates v7.4.0 v8.0.0 labels Aug 26, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalger spalger merged commit 075c68b into master Aug 27, 2019
spalger pushed a commit to spalger/kibana that referenced this pull request Aug 27, 2019
@renovate renovate bot deleted the renovate/babel branch August 27, 2019 21:10
spalger pushed a commit that referenced this pull request Aug 28, 2019
@spalger
Copy link
Contributor

spalger commented Aug 28, 2019

7.x/7.4: 8660e0b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported release_note:skip Skip the PR/issue when compiling release notes renovate Renovate dependency update with major version updates v7.4.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants