You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes our references to autonomous_system.* change to as.* in the SIEM app. I don't see any data coming through for autonomous_system.* in the first place. After this change, we are getting that data now when it is there on Ip Overview #43746
Checklist
Use strikethroughs to remove checklist items you don't feel are applicable to this PR.
When the text field gets large, it will cause line breaks and visually looks a bit off, but no changes requested. We could in the future maybe truncate it and make the tooltip display the full name or another option might be to split apart the Autonomous System Number into its own separate field next the Autonomous System Name.
The other thing I noticed when testing this is that when we "flip" between "source" and "destination through the drop-down it does not auto-refresh any of the data. Instead the user has to manually click refresh to get the data to update.
This looks to be true for the ASN information as well as for any data in that UI component such as the ML data.
Here is a screen shot before I clicked "refresh" showing the source as a draggable instead of destination after I clicked "destination".
It fixes its self once I click "refresh" on the time range.
Just FYI's in case this is a recent issue but it can always be solved in a different PR later.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ECS has added an
as.*field set (elastic/ecs#341, docs) and @andrewkroh has updated a bunch of Filebeat pipelines to use those fields (elastic/beats#13036).This PR changes our references to
autonomous_system.*change toas.*in the SIEM app. I don't see any data coming through forautonomous_system.*in the first place. After this change, we are getting that data now when it is there on Ip Overview#43746
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately