Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [ftr] enable visualRegression jobs (#42989) #43124

Merged
merged 2 commits into from
Aug 12, 2019
Merged

[7.x] [ftr] enable visualRegression jobs (#42989) #43124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea9b001
[ftr] enable visualRegression jobs (#42989)
Aug 12, 2019
a39b37b
Merge branch '7.x' of github.com:elastic/kibana into backport/7.x/pr-…
Aug 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .ci/jobs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ JOB:
- kibana-ciGroup10
- kibana-ciGroup11
- kibana-ciGroup12
# - kibana-visualRegression
- kibana-visualRegression

# make sure all x-pack-ciGroups are listed in test/scripts/jenkins_xpack_ci_group.sh
- x-pack-firefoxSmoke
Expand All @@ -28,7 +28,7 @@ JOB:
- x-pack-ciGroup8
- x-pack-ciGroup9
- x-pack-ciGroup10
# - x-pack-visualRegression
- x-pack-visualRegression

# `~` is yaml for `null`
exclude: ~
2 changes: 1 addition & 1 deletion test/visual_regression/tests/console_app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export default function({ getService, getPageObjects }: FtrProviderContext) {
const visualTesting = getService('visualTesting');
const PageObjects = getPageObjects(['common', 'console']);

describe('console app', function describeIndexTests() {
describe.skip('console app', function describeIndexTests() {
before(async () => {
log.debug('navigateTo console');
await PageObjects.common.navigateToApp('console');
Expand Down
3 changes: 2 additions & 1 deletion x-pack/test/visual_regression/tests/login_page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export default function ({ getService, getPageObjects }) {
const PageObjects = getPageObjects(['common', 'security']);

describe('Security', () => {
describe('Login Page', () => {
describe.skip('Login Page', () => {
before(async () => {
await esArchiver.load('empty_kibana');
await PageObjects.security.logout();
Expand All @@ -28,6 +28,7 @@ export default function ({ getService, getPageObjects }) {

it('renders login page', async () => {
await PageObjects.common.navigateToApp('login');

await retry.waitFor('login page visible', async () => (
await testSubjects.exists('loginSubmit')
));
Expand Down