Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Support x-pack plugins in new platform #39454

Merged
merged 5 commits into from
Jun 24, 2019

Conversation

epixa
Copy link
Contributor

@epixa epixa commented Jun 21, 2019

Unless Kibana is running as oss-only, the x-pack plugins path is
configured in the environment for use in plugin discovery.

Closes #39447

Unless Kibana is running as oss-only, the x-pack plugins path is
configured in the environment for use in plugin discovery.
@epixa epixa added Feature:Plugins Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. v8.0.0 v7.3.0 labels Jun 21, 2019
@epixa epixa requested a review from a team as a code owner June 21, 2019 16:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@elasticmachine

This comment has been minimized.

Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with copying the testbed plugin to x-pack and it worked 👍

@elasticmachine

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@Bamieh
Copy link
Member

Bamieh commented Jun 24, 2019

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@joshdover joshdover self-assigned this Jun 24, 2019
@joshdover joshdover merged commit ed4549a into elastic:master Jun 24, 2019
joshdover pushed a commit to joshdover/kibana that referenced this pull request Jun 24, 2019
* Include x-pack plugin path when appropriate

Unless Kibana is running as oss-only, the x-pack plugins path is
configured in the environment for use in plugin discovery.
joshdover added a commit that referenced this pull request Jun 24, 2019
* Include x-pack plugin path when appropriate

Unless Kibana is running as oss-only, the x-pack plugins path is
configured in the environment for use in plugin discovery.
@rayafratkina
Copy link
Contributor

@epixa can you please add a Dev Doc section to the PR for the API changes blog?

@epixa epixa deleted the np-plugins-in-xpack branch July 12, 2019 14:39
@epixa epixa added non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes and removed release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. non-issue Indicates to automation that a pull request should not appear in the release notes labels Jul 12, 2019
@epixa
Copy link
Contributor Author

epixa commented Jul 12, 2019

@rayafratkina This isn't relevant to plugin developers as it only pertains to code in the Kibana repo which has already been updated to support the change, so I've switched this to skip instead of dev_docs. Thanks for the ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:New Platform Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.3.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support x-pack plugins in new platform
5 participants