Added kibana_index_replicas property to kibana.yml. #3878
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he number of replicas for the index used to store Kibana dashboards, settings, etc. in Elasticsearch. Resolves elastic#3877.
…railing spaces stripped by my editor that obscured the meaningful change.
|
Instead of going this route we're simply going to remove the explicit setting of replicas: 1, which will allow you to accomplish this with an elasticsearch template. There's really no good reason for Kibana to set the number of replicas FWIW, we only set it to 1 on creation, it can be turned down immediately after creation. |
|
Closed per discussion on #3877 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added supporting code and documentation to provide a default value (1) for the property, make the value accessible to the browser app, and to use the setting when creating a new Kibana index in Elasticsearch.
There is probably an opportunity to add some test cases for these changes. I'm not very familiar with javascript testing frameworks, and I didn't see examples I could base my tests off of for the files being changed. Suggestions for how to automate testing of these changes are welcome, with pointers to examples of testing similar code greatly appreciated. I did manually test these changes with values of 0 and 1 for kibana_index_replicas in kibana.yml.
This is intended to resolve #3877.