Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] A <label> for time bucket size selector on discover #38396

Merged
merged 4 commits into from
Jun 12, 2019
Merged

[Accessibility] A <label> for time bucket size selector on discover #38396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
582c51e
Replace <span> with a <label for=''> used as a label for a dropdown <…
PhilippBaranovskiy Jun 7, 2019
1b89967
Change CSS selector for functional test
PhilippBaranovskiy Jun 11, 2019
5ea1824
Change CSS selector for functional test
PhilippBaranovskiy Jun 11, 2019
65a59df
Merge branch 'master' into 19448
PhilippBaranovskiy Jun 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/legacy/core_plugins/kibana/public/discover/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,16 +129,18 @@ <h1 id="kui_local_breadcrumb" class="kuiLocalBreadcrumb" ng-if="opts.savedSearch
>
<header class="dscTimechart__header">
<div class="small">
<span
<label
for="dscResultsIntervalSelector"
tooltip="{{::'kbn.discover.howToChangeTheTimeTooltip' | i18n: {defaultMessage: 'To change the time, click the clock icon in the navigation bar'} }}"
>
{{toMoment(timeRange.from)}} - {{toMoment(timeRange.to)}}
</span>
</label>

&mdash;

<span class="form-inline">
<select
id="dscResultsIntervalSelector"
class="dscResults__interval form-control"
ng-model="state.interval"
ng-options="interval.val as interval.display for interval in intervalOptions | filter: intervalEnabled"
Expand Down
2 changes: 1 addition & 1 deletion test/functional/page_objects/discover_page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export function DiscoverPageProvider({ getService, getPageObjects }) {
}

async getChartTimespan() {
const el = await find.byCssSelector('.small > span:nth-child(1)');
const el = await find.byCssSelector('.small > label[for="dscResultsIntervalSelector"]');
return await el.getVisibleText();
}

Expand Down