-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic Y-Axis Sizing #3749
Dynamic Y-Axis Sizing #3749
Conversation
after the axis labels have been rendered and the size of the element can be checked
@stormpython once reviewed, please please pass it to someone else to get a second set of eyes on it. |
so that the x-axis sizing is done against the adjusted size
@w33ble I found two issues. The first happens when numbers grow larger than 1 million, and the second happens when labels along the x-axis are rotated. See screenshots below.
|
also localize the variables
use the yAxis instance that was passed through
@stormpython should be in better shape now. I'm assigning the width as part of the layout, using a rendered version of the y-axis to get the width at that step. Take another look and let me know if you see issues. |
@w33ble LGTM! I am going to assign another person to review this just to make sure I didn't miss something. |
LGT:m:! |
Closes #2693