Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSVB] Rollup Search - override index pattern functionality is not working with Rollup search #36641

Merged
merged 14 commits into from
May 24, 2019

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented May 17, 2019

Summary

  • Design issue was fixed. Panel Index Pattern shouldn't be saved in SearchRequest object. Instead of that search request should be executed with two arguments: request body + index for which we are going to execute the search query.

From:

     const { searchStrategy, capabilities } = await SearchStrategiesRegister.getViableStrategy(req, panelIndexPattern);
       const searchRequest = searchStrategy.getSearchRequest(req, **panelIndexPattern**);

       searchRequest.search({body});

To:

   const { searchStrategy, capabilities } = await SearchStrategiesRegister.getViableStrategyForPanel(req, panel);
  const searchRequest = searchStrategy.getSearchRequest(req);

     searchRequest.search([{body, index}]);
  • batchRequestsSupport property was removed.
  • For getting the SearchStrategy we use the extractIndexPatterns method. This method returns a full list of used indexes for visualization.

Screen:

image

Depends on #36081

Checklist

For maintainers

@alexwizp alexwizp requested a review from sulemanof May 17, 2019 11:22
@alexwizp
Copy link
Contributor Author

retest

@elastic elastic deleted a comment from elasticmachine May 17, 2019
@elastic elastic deleted a comment from elasticmachine May 17, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@alexwizp alexwizp marked this pull request as ready for review May 21, 2019 10:15
@alexwizp alexwizp requested a review from a team May 21, 2019 10:15
@alexwizp alexwizp added Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels May 21, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@alexwizp alexwizp requested a review from TinaHeiligers May 21, 2019 10:18
@alexwizp alexwizp requested review from timroes and markov00 May 21, 2019 10:18
@alexwizp alexwizp added the release_note:skip Skip the PR/issue when compiling release notes label May 21, 2019
Copy link
Contributor

@PhilippBaranovskiy PhilippBaranovskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with Rollup logic, however, the code looks good to me.

@PhilippBaranovskiy PhilippBaranovskiy self-requested a review May 21, 2019 14:23
@alexwizp alexwizp requested a review from emmacunningham May 22, 2019 15:31
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall code lgtm. I've added few comments to address before merge

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants