-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TSVB] Rollup Search - override index pattern functionality is not working with Rollup search #36641
Conversation
… which were created in Calendar intervals
… which were created in Calendar intervals
retest |
💚 Build Succeeded |
💚 Build Succeeded |
Pinging @elastic/kibana-app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with Rollup logic, however, the code looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall code lgtm. I've added few comments to address before merge
src/legacy/core_plugins/metrics/server/lib/vis_data/helpers/unit_to_seconds.test.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/rollup/server/lib/search_strategies/rollup_search_capabilities.test.js
Outdated
Show resolved
Hide resolved
...ore_plugins/metrics/server/lib/search_strategies/strategies/abstract_search_strategy.test.js
Outdated
Show resolved
Hide resolved
src/legacy/core_plugins/metrics/server/lib/search_strategies/default_search_capabilities.js
Show resolved
Hide resolved
src/legacy/core_plugins/metrics/server/lib/search_strategies/searh_requests/search_request.js
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
…rking with Rollup search (elastic#36641)
…rking with Rollup search (elastic#36641)
Summary
Panel Index Pattern
shouldn't be saved inSearchRequest
object. Instead of that search request should be executed with two arguments: request body + index for which we are going to execute the search query.From:
To:
Screen:
Depends on #36081
Checklist
This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers