-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TSVB wrong default date field on default index-pattern #36519
Conversation
Pinging @elastic/kibana-app |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I would also set the default time interval as a placeholder
@sulemanof default value for time interval is not related to these changes but it was already fixed in the following PR #36081 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Tested locally changing default index patterns and using different override index patterns.
Fix: #36264
Summary
When creating a fresh TSVB visualization, the default index pattern is used.
The first data query is then issued with that default index-pattern against what should be the default date field. I said "should be" because if I'm not currently seeing this behaviour if I'm using the kibana_sample_data_ecommerce that has the order_date as default date field instead of the standard @timestamp.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers