Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSVB wrong default date field on default index-pattern #36519

Merged
merged 1 commit into from
May 23, 2019

Conversation

alexwizp
Copy link
Contributor

Fix: #36264

Summary

When creating a fresh TSVB visualization, the default index pattern is used.
The first data query is then issued with that default index-pattern against what should be the default date field. I said "should be" because if I'm not currently seeing this behaviour if I'm using the kibana_sample_data_ecommerce that has the order_date as default date field instead of the standard @timestamp.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@alexwizp alexwizp requested review from a team and TinaHeiligers May 13, 2019 10:54
@alexwizp alexwizp added Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels May 13, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@alexwizp alexwizp added v7.2.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels May 13, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@sulemanof sulemanof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I would also set the default time interval as a placeholder

@alexwizp
Copy link
Contributor Author

@sulemanof default value for time interval is not related to these changes but it was already fixed in the following PR #36081

Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Tested locally changing default index patterns and using different override index patterns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSVB wrong default date field on default index-pattern
4 participants