Reenable Rollup Jobs API test that was failing due to interval change in ES #36310
Conversation
|
Pinging @elastic/es-ui |
|
I think we should also change the payload to use |
|
While you're in this code, do you think it would be a large effort to update the detail panel UI? The interval value is currently blank when the above coercion happens:
|
|
We discussed this in Slack and decided to leave the payload as-is, since that reflects the reality of what kind of payload is generated by the UI. The right time to update this test code is when we address #36306. |
|
@jen-huang Great catch re the detail panel! I just pushed a fix. Could you take another look please?
|
💚 Build Succeeded |
💚 Build Succeeded |
| @@ -24,7 +24,7 @@ export default function ({ getService }) { | |||
| cleanUp, | |||
| } = registerHelpers({ supertest, es }); | |||
|
|
|||
| describe('jobs', () => { | |||
| describe('Rollup jobs', () => { | |||
There was a problem hiding this comment.
This was written like this on purpose as each "describe" creates a section.
Its parent is "Rollup". So we would read the test like this: Rollup -> jobs -> Index patterns -> <should ...>.
| @@ -139,7 +138,11 @@ export default function ({ getService }) { | |||
| 'testCreatedField': { | |||
| 'agg': 'date_histogram', | |||
| 'delay': '1d', | |||
| 'interval': '24h', | |||
| // TODO: Note that we created the job with `interval`, but ES has coerced this to | |||
There was a problem hiding this comment.
Why don't we address it in this PR?
[edit]: sorry, just tested trying to provide "fixed_interval" in the payload and apparently it is not yet supported. So if I understand well, the create job API needs interval to be provided but the get job API returns fixed_interval?
There was a problem hiding this comment.
interval is deprecated, but still supported. When ES receives interval it will coerce it into either fixed_interval or calendar_interval, which is why we see one of those when getting the rollup capabilities/job from ES. Jen opened #36306 to update the UI at some point to support creation of a rollup job with either fixed_interval or calendar_interval, instead of interval, but it's not a necessary change at the moment.
💚 Build Succeeded |
|
These tests run fine and passed for me locally. I also checked to make sure that we were checking some sad paths in our coverage. Good to go there. |
💚 Build Succeeded |
Fixes #36269
I did a quick run-through of the UI to verify things still work correctly. Rollup jobs look like they can be created and run just fine. Testing of Visualize was blocked by #36295