Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put refresh interval on global state so it can be set via URL. #2949

Merged
merged 2 commits into from
Mar 18, 2015

Conversation

jribble
Copy link
Contributor

@jribble jribble commented Feb 9, 2015

Instead of saving the refresh interval on session storage, put in into global state so it's put into the URL. This allows including refresh rate in embedded URL so it can be used in a NOC style dashboard. This takes care of issue #2901.

@sqpdln
Copy link

sqpdln commented Feb 19, 2015

+1 for this!

@mycrEEpy
Copy link

mycrEEpy commented Mar 4, 2015

+1 we need this

@rashidkpc rashidkpc added review help wanted adoptme and removed help wanted adoptme labels Mar 4, 2015
@panda01 panda01 self-assigned this Mar 6, 2015
// These can be date math strings or moments.
self.time = _.defaults(globalState.time || {}, timeDefaults);
self.refreshInterval = _.defaults(globalState.time || {}, refreshIntervalDefaults);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, isn't this supposed to be globalState.refreshInterval?

@jribble
Copy link
Contributor Author

jribble commented Mar 9, 2015

Oops, yes, thanks.

@panda01 panda01 self-assigned this Mar 13, 2015
@nithyanv
Copy link

Hi, when can we see this functioning? I have latest git at 9c98861 today (18.03.2015)

@panda01 panda01 added bug Fixes for quality problems that affect the customer experience v4.0.2 and removed v4.1.0 labels Mar 18, 2015
@panda01
Copy link
Contributor

panda01 commented Mar 18, 2015

LGTM

panda01 added a commit that referenced this pull request Mar 18, 2015
Put refresh interval on global state so it can be set via URL.
@panda01 panda01 merged commit 49bf0e5 into elastic:master Mar 18, 2015
@lukas2
Copy link

lukas2 commented May 7, 2015

I was looking for this, but can't find the documentation on how to set that parameter within the URL. What's the format? something similar to this perhaps: http://somehost.com/index.html#/dashboard/elasticsearch/SomeDsahboard?refreshInterval=10
?

@jribble
Copy link
Contributor Author

jribble commented May 8, 2015

The URL is updated automatically as you add an interval. So you can see the format if you set a refresh interval on any view. The format is a bit more complicated than that because it represents the internal structure more than a simple parameter.

@dalenewman
Copy link

@lukas2 something more like this:

?embed=true&_g=(refreshInterval:(display:'10%20seconds',pause:!f,section:1,value:10000))

This is an example where refresh interval is set to 10 seconds. (value:10000 is ms)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience review v4.0.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants