-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put refresh interval on global state so it can be set via URL. #2949
Conversation
+1 for this! |
+1 we need this |
// These can be date math strings or moments. | ||
self.time = _.defaults(globalState.time || {}, timeDefaults); | ||
self.refreshInterval = _.defaults(globalState.time || {}, refreshIntervalDefaults); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, isn't this supposed to be globalState.refreshInterval
?
Oops, yes, thanks. |
Hi, when can we see this functioning? I have latest git at 9c98861 today (18.03.2015) |
LGTM |
Put refresh interval on global state so it can be set via URL.
I was looking for this, but can't find the documentation on how to set that parameter within the URL. What's the format? something similar to this perhaps: http://somehost.com/index.html#/dashboard/elasticsearch/SomeDsahboard?refreshInterval=10 |
The URL is updated automatically as you add an interval. So you can see the format if you set a refresh interval on any view. The format is a bit more complicated than that because it represents the internal structure more than a simple parameter. |
@lukas2 something more like this:
This is an example where refresh interval is set to 10 seconds. (value:10000 is ms) |
Instead of saving the refresh interval on session storage, put in into global state so it's put into the URL. This allows including refresh rate in embedded URL so it can be used in a NOC style dashboard. This takes care of issue #2901.