-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ILM] Fix Index Management not loading when ILM enricher errors out #28108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/es-ui |
💔 Build Failed |
Failed on unrelated test (#27922):
|
💚 Build Succeeded |
bmcconaghy
approved these changes
Jan 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
This was referenced Jan 7, 2019
jen-huang
added a commit
to jen-huang/kibana
that referenced
this pull request
Jan 7, 2019
…lastic#28108) * Only load ILM data enricher if UI is enabled * Silently swallow errors from data enrichers * Only add index management ILM extensions if ILM UI is enabled
jen-huang
added a commit
to jen-huang/kibana
that referenced
this pull request
Jan 7, 2019
…lastic#28108) * Only load ILM data enricher if UI is enabled * Silently swallow errors from data enrichers * Only add index management ILM extensions if ILM UI is enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
review
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
v6.6.0
v6.7.0
v7.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28087
On Cloud, Index Management fails to load. This fixes the issue by:
Locally, this can be tested by setting
xpack.ilm.ui.enabled: false
inkibana.yml
and changing this request URL to/*/_ilm/somebadurl
. Without this fix, observe that Index Management page shows no indices (no system indices either) and displays an error toast. After applying this fix, page should function normally.In addition, I also found that ILM is extending Index Management UI ("Add lifecycle policy" as a management option, etc) regardless of
xpack.ilm.ui.enabled
, I've adjust the extension registration so that they are only registered when UI is enabled.