Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x] Move timeout to _msearch body in TSVB requests (#26510) #26515

Merged
merged 1 commit into from
Dec 4, 2018
Merged

[6.x] Move timeout to _msearch body in TSVB requests (#26510) #26515

merged 1 commit into from
Dec 4, 2018

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Dec 3, 2018

Backports the following commits to 6.x:

@elasticmachine
Copy link
Contributor

💔 Build Failed

@ppisljar
Copy link
Member Author

ppisljar commented Dec 3, 2018

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@kobelb
Copy link
Contributor

kobelb commented Dec 3, 2018

We'll likely want to backport this to 6.5, as these timeouts aren't working there either, they're just being ignored:

This use of timeout in the metadata line was never supported, we leniently accepted it but it did not do anything. We have deprecated this leniency in 6.x (6.6.0) with elastic/elasticsearch#36014 and as you know have removed the leniency in master (7.0.0).

@ppisljar
Move timeout to _msearch body in TSVB requests (elastic#26510)
a70c5a7 
* fixing broken tsvb

* removing `ignore: [404]`
@ppisljar ppisljar force-pushed the backport/6.x/pr-26510 branch from 336eb6d to a70c5a7 Compare December 4, 2018 10:01
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@ppisljar ppisljar merged commit 118081a into elastic:6.x Dec 4, 2018
@ppisljar ppisljar deleted the backport/6.x/pr-26510 branch December 4, 2018 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ppisljar @elasticmachine @kobelb