Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/API changes to facilitate disabling features within spaces #24235

Merged
merged 31 commits into from
Nov 29, 2018
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
111927d
GAP - Actions Restructured and Extensible (#25347)
kobelb Nov 16, 2018
a95035a
Restructure user profile for granular app privs (#23750)
legrego Nov 5, 2018
839d99d
Introducing uiCapabilities, removing config providers & user profile …
legrego Nov 14, 2018
6cffcaa
Restructure user profile for granular app privs (#23750)
legrego Nov 5, 2018
ec7ac1f
Introducing uiCapabilities, removing config providers & user profile …
legrego Nov 14, 2018
ad1d89a
Begin to allow features to be disabled within spaces
legrego Oct 3, 2018
ad844b6
extract migration logic into testable unit
legrego Nov 13, 2018
8ad25eb
Design edits (#12)
cchaos Nov 14, 2018
aba4ec8
fix i18n
legrego Nov 16, 2018
fd0016d
updates toggleUiCapabilities to use new feature definitions
legrego Nov 16, 2018
c96e69f
cleanup and testing
legrego Nov 16, 2018
cef1003
remove references to old feature interface
legrego Nov 16, 2018
6f570d0
readd lost spacer
legrego Nov 16, 2018
81b670d
adds feature route testing
legrego Nov 16, 2018
d6b4553
additional i18n
legrego Nov 16, 2018
dbdd66c
snapshot update
legrego Nov 26, 2018
de181d8
copy edits
legrego Nov 26, 2018
16de935
fix ml app icon
legrego Nov 26, 2018
d3cc25c
add missing export
legrego Nov 26, 2018
7b4c985
remove unnecessary sass import
legrego Nov 26, 2018
d129ead
attempt to fix build
legrego Nov 26, 2018
626a11d
fix spaces api tests
legrego Nov 26, 2018
8cbbade
esArchiver mapping updates
legrego Nov 26, 2018
33f151f
rename toggleUiCapabilities -> toggleUICapabilities
legrego Nov 28, 2018
7ba8c4e
removes shared collapsible_panel component in favor of plugin-specifi…
legrego Nov 28, 2018
53c89e4
some copy and style adjustments
legrego Nov 28, 2018
a352ce9
fix test following rebase
legrego Nov 28, 2018
92d9758
add lost types file
legrego Nov 28, 2018
31a3a7e
design edits
legrego Nov 28, 2018
0dd66b1
remove stale export
legrego Nov 28, 2018
2156e5b
feature feedback; fixes cached disabled features
legrego Nov 29, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
some copy and style adjustments
  • Loading branch information
legrego committed Nov 28, 2018
commit 53c89e494c1f81bab2d34fc43dad59a626fd79c4
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ exports[`it renders without blowing up 1`] = `
grow={false}
>
<EuiTitle
size="m"
size="xs"
textTransform="none"
>
<h2>
<h3>
<React.Fragment>
<EuiIcon
className="collapsiblePanel__logo"
Expand All @@ -33,7 +33,7 @@ exports[`it renders without blowing up 1`] = `

</React.Fragment>
Elasticsearch
</h2>
</h3>
</EuiTitle>
</EuiFlexItem>
<EuiFlexItem
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ export class CollapsiblePanel extends Component<Props, State> {
// @ts-ignore
<EuiFlexGroup alignItems={'baseline'} gutterSize="s" responsive={false}>
<EuiFlexItem grow={false}>
<EuiTitle>
<h2>
<EuiTitle size={'xs'}>
<h3>
{this.props.iconType && (
<Fragment>
<EuiIcon
Expand All @@ -65,7 +65,7 @@ export class CollapsiblePanel extends Component<Props, State> {
</Fragment>
)}
{this.props.title}
</h2>
</h3>
</EuiTitle>
</EuiFlexItem>
<EuiFlexItem grow={false}>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export class EnabledFeatures extends Component<Props, {}> {
<span>
<FormattedMessage
id="xpack.spaces.management.enabledSpaceFeatures.enabledFeaturesSectionMessage"
defaultMessage="Change feature display"
defaultMessage="Control feature display"
/>{' '}
{details}
</span>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ class ManageSpacePageUI extends Component<Props, State> {
if (this.editingExistingSpace()) {
return `Edit space`;
}
return `Create space`;
return `Create a space`;
};

public maybeGetSecureSpacesMessage = () => {
Expand Down