Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Remove draggable wrapper and data provider props #212589

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

christineweng
Copy link
Contributor

@christineweng christineweng commented Feb 26, 2025

Summary

This PR is a follow up clean up of draggables after this PR that removed isDraggable prop everywhere. This is part 1 of the draggable clean ups listed in #212593.

Included in this PR:

  1. Removed DraggableWrapper and moved the truncate logic into CellActionsWrapper
  2. Removed the creation of data provider props in DefaultDraggable. The security cell actions only require field and value, so creating the data provider object and later taking just the query fields are redundant.
  3. Updated components that call DraggableWrapper directly, and remove any draggable references
  4. Remove data provider id in unit tests
Before and after in flow charts

Before
*props in red are used to create data provider and hence obsolete
image

After
image

Checklist

  • Unit or functional tests were updated or added to match the most common scenarios
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

@christineweng christineweng added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Feb 26, 2025
@christineweng christineweng self-assigned this Feb 26, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 26, 2025

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!
  • Click to trigger kibana-deploy-cloud-from-pr for this PR!

export interface DraggableWrapperProps {
dataProvider: DataProvider;
fieldType?: string;
isAggregatable?: boolean;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to pass isAggregatable to the new cell actions?

@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 26, 2025

💔 Build Failed

Failed CI Steps

History

cc @christineweng

@christineweng christineweng force-pushed the remove-draggable-wrapper branch from c748cc1 to 296cdc9 Compare February 26, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants