[8.x] 🌊 Move streams to platform #212113
Open
[8.x] 🌊 Move streams to platform #212113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR moves the `streams` and `streams_app` plugins into platform so they can be used in other solutions in the future. This PR is not actually making it available in other solutions yet since we are still discussing the release plans. ## Inlined helpers As discussed before, this PR inlines a couple simple helper methods for query building, time zone normalization, a header portal helper and a data plugin timefilter state react integration hook as there is no good place for these outside of the observability solution. ## streams_app plugin The streams_app plugin is not actually registering anything, instead it simply exports a component that renders the app which needs to be consumed by another plugin to turn it into a registered app - for now, `observability_streams_wrapper` takes over this job. ## observability_streams_wrapper plugin While 99% of the streams logic is moved into the `platform/shared/streams_app`, two bits are left behind in `observability_streams_wrapper`: * The actual app registration * Integration with the observability_shared `PageTemplate` component Once we decide streams should be displayed outside of the observability solution, it's probably not necessary anymore to decouple app definition and registration like this because it will always be visible no matter the solution. Once this is the case, the navigation registration can be moved into the central `observability` plugin, like it's handled with other apps like infra. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 8a9bb36) # Conflicts: # .github/CODEOWNERS # x-pack/platform/plugins/shared/streams/server/routes/streams/group/route.ts # x-pack/platform/plugins/shared/streams_app/kibana.jsonc
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled in files
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
|
dgieselaar
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x: