Doc viewer app #2121
Doc viewer app #2121
Conversation
|
|
||
| var computedFields = $scope.indexPattern.getComputedFields(); | ||
|
|
||
| es.search({ |
There was a problem hiding this comment.
Q: Why a search here?
A: Elasticsearch GET API doesn't support stored or scripted fields, have to go through the search API
Q: Well then why didn't you use a searchSource?
A: It seemed wasteful to start up a temporary indexPattern and searchSource for one request. I would need to new up an indexPattern as the existing one could match some range of indices, and I need exactly one index. The indexPattern that does get loaded here is only used for formatters and scripted fields retrieval.
| @@ -0,0 +1,13 @@ | |||
| define(function (require, module, exports) { | |||
| require('plugins/doc/controllers/doc'); | |||
| require('css!plugins/doc/styles/main.css'); | |||
There was a problem hiding this comment.
This isn't actually being compiled. Also, there doesn't appear to be any rules in plugins/doc/styles/main.less.
|
There's a weird style issue. I fixed it in rashidkpc#1
|
|
So, remove that unused LESS file, and merge/modify that PR I sent you, and this LGTM |
fix dov viewer tab style
|
🍐 |
This allows users to open and share a link to exactly one document. Closes #717