[Obs Onboarding] Migrate API test to deployment agnostic framework #211548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
c91e0fd to
e57b6fb
Compare
dmlemeshko
reviewed
Feb 18, 2025
Comment on lines
19
to
26
| before(async () => { | ||
| viewerClient = await roleScopedSupertest.getSupertestWithRoleScope('viewer', { | ||
| withInternalHeaders: true, | ||
| }); | ||
| adminClient = await roleScopedSupertest.getSupertestWithRoleScope('admin', { | ||
| withInternalHeaders: true, | ||
| }); | ||
| }); |
There was a problem hiding this comment.
we need to invalidate api keys after tests executed:
after(async () => {
viewerClient.destroy();
adminClient.destroy();
});
There was a problem hiding this comment.
maybe good to rename to viewClientWithAPIKey and adminClientWithAPIKey for visiblity
There was a problem hiding this comment.
Thanks! Renamed the variables and added after
e57b6fb to
4903a06
Compare
dmlemeshko
approved these changes
Feb 18, 2025
⏳ Build in-progress
History
|
awahab07
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes 206953
This change migrates mosts of the Obs Onboarding API tests to the deployment agnostic framework. A few tests has to be still left in the deployment-specific setup because they require a custom roles which are not supported in the deployment agnostic setup for serverless-oblt.