Fix SolutionNav padding in pages that use overridden EUI breakpoints
#211513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… APM's custom xxl and xxxl sizes
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
cc @tkajtoch |
delanni
approved these changes
Feb 18, 2025
kowalczyk-krzysztof
approved these changes
Feb 18, 2025
|
Starting backport for target branches: 9.0 https://github.com/elastic/kibana/actions/runs/13387413193 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 18, 2025
elastic#211513) (cherry picked from commit ff2e3dd)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 18, 2025
…kpoints (#211513) (#211535) # Backport This will backport the following commits from `main` to `9.0`: - [Fix `SolutionNav` padding in pages that use overridden EUI breakpoints (#211513)](#211513) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Tomasz Kajtoch","email":"tomasz.kajtoch@elastic.co"},"sourceCommit":{"committedDate":"2025-02-18T09:31:23Z","message":"Fix `SolutionNav` padding in pages that use overridden EUI breakpoints (#211513)","sha":"ff2e3dd36f4d9b0dd1705bc0e1235fc5fa92a94c","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","v9.1.0"],"title":"Fix `SolutionNav` padding in pages that use overridden EUI breakpoints","number":211513,"url":"https://github.com/elastic/kibana/pull/211513","mergeCommit":{"message":"Fix `SolutionNav` padding in pages that use overridden EUI breakpoints (#211513)","sha":"ff2e3dd36f4d9b0dd1705bc0e1235fc5fa92a94c"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211513","number":211513,"mergeCommit":{"message":"Fix `SolutionNav` padding in pages that use overridden EUI breakpoints (#211513)","sha":"ff2e3dd36f4d9b0dd1705bc0e1235fc5fa92a94c"}}]}] BACKPORT--> Co-authored-by: Tomasz Kajtoch <tomasz.kajtoch@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #211474
This PR fixes a bug introduced in #207008 that caused the
<SolutionNav />component to not have thepaddingstyle defined when rendered on certain Observability pages.The underlying issue was caused by
useEuiBreakpoint(['m', 'l', 'xl'])hook to define breakpoints while the APM, Synthetics, and User Experience apps modify the default EUI breakpoints to add customxxl(>=1600px) andxxxl(>=2000px) levels. This breakpoint modification resulted in not all breakpoint levels being recognized as matching and thepaddingstyle not applied.Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelines