Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [SecuritySolution] Apply different color tokens for themes (#206254) #210993

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

angorayc
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…06254)

## Summary

Previous changes applied same tokens for Borealis and Amsterdam:
elastic#204631 (comment)

PR above causes color changes to the current theme, after discussing
with UX, we decide to maintain different color tokens until Borealis is
launched. This PR should revert the color changed on Amsterdam by the
previous PR and only apply the new color for Borealis.

| Current and Amsterdam | Borealis  |
|-------------------------|----------|
|Source: Hard coded: `#d36186`|Source: `euiColorVis4` - `#EE72A6` |
|Dest: Hard coded: `#9170b8` |Dest: `euiColorVis2` - `#61A2FF`|

### Host IPs:

| Current and Amsterdam | Borealis  |
|-------------------------|----------|
|<img width="2560" alt="host_IPs"
src="https://github.com/user-attachments/assets/c0f9f317-fb02-4c96-8422-c1d2484f4636"
/>|<img width="2560" alt="host_bor_light"
src="https://github.com/user-attachments/assets/451d6604-1d7c-4a2e-82c3-74b2499852d2"
/>|
|<img width="2558" alt="host_IPs_dark"
src="https://github.com/user-attachments/assets/ac45a3ac-ecaf-46b6-91d9-68704d8639ee"
/>|<img width="2553" alt="host_bor_dark"
src="https://github.com/user-attachments/assets/e34e56fd-8202-4a3c-80c1-996718320fd8"
/>|

### Network IPs:

| Current and Amsterdam | Borealis  |
|-------------------------|----------|
|<img width="2557" alt="network_IPs"
src="https://github.com/user-attachments/assets/0e0b33d9-55b7-41a5-8910-11b80e539398"
/>|<img width="2559" alt="network_bor_light"
src="https://github.com/user-attachments/assets/f616b3ab-5032-4e69-b67e-cde39b88ea5f"
/>|
|<img width="2558" alt="host_IPs_dark"
src="https://github.com/user-attachments/assets/9613a49f-f0c6-4b63-aa56-c960fac175fc"
/>|<img width="2560" alt="network_bor_dark"
src="https://github.com/user-attachments/assets/911f0509-43ea-428a-94d6-9ce01f5425ac"
/>|

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 4ca5779)
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 6729 6730 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 18.7MB 18.7MB -189.0B

@angorayc angorayc merged commit 0a314bd into elastic:8.x Feb 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants