[Dataset quality] 🐞 Rely solely on _index instead of data_stream properties #210329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starting backport for target branches: 8.16, 8.17, 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/13261182414 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 11, 2025
…erties (elastic#210329) Closes elastic/logs-dev#192. ## Background This have been an long running issue within dataset quality page which became more noticeable when introducing failure store. Before this change `Dataset quality details` page was already solely relying on `_index` instead of filtering documents using `data_stream` properties while the main page was filtering out the documents. ### Before https://github.com/user-attachments/assets/02d14cb9-81a6-4f61-a199-5d1e55443a20 ### After https://github.com/user-attachments/assets/09a4e523-b927-4147-99d1-6ceff40f1027 (cherry picked from commit d26f9ff)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 11, 2025
…erties (elastic#210329) Closes elastic/logs-dev#192. ## Background This have been an long running issue within dataset quality page which became more noticeable when introducing failure store. Before this change `Dataset quality details` page was already solely relying on `_index` instead of filtering documents using `data_stream` properties while the main page was filtering out the documents. ### Before https://github.com/user-attachments/assets/02d14cb9-81a6-4f61-a199-5d1e55443a20 ### After https://github.com/user-attachments/assets/09a4e523-b927-4147-99d1-6ceff40f1027 (cherry picked from commit d26f9ff)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 11, 2025
…erties (elastic#210329) Closes elastic/logs-dev#192. ## Background This have been an long running issue within dataset quality page which became more noticeable when introducing failure store. Before this change `Dataset quality details` page was already solely relying on `_index` instead of filtering documents using `data_stream` properties while the main page was filtering out the documents. ### Before https://github.com/user-attachments/assets/02d14cb9-81a6-4f61-a199-5d1e55443a20 ### After https://github.com/user-attachments/assets/09a4e523-b927-4147-99d1-6ceff40f1027 (cherry picked from commit d26f9ff)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 11, 2025
…am properties (#210329) (#210532) # Backport This will backport the following commits from `main` to `8.18`: - [[Dataset quality] 🐞 Rely solely on _index instead of data_stream properties (#210329)](#210329) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yngrid Coello","email":"yngrid.coello@elastic.co"},"sourceCommit":{"committedDate":"2025-02-11T10:48:45Z","message":"[Dataset quality] 🐞 Rely solely on _index instead of data_stream properties (#210329)\n\nCloses https://github.com/elastic/logs-dev/issues/192.\r\n\r\n## Background\r\n\r\nThis have been an long running issue within dataset quality page which\r\nbecame more noticeable when introducing failure store. Before this\r\nchange `Dataset quality details` page was already solely relying on\r\n`_index` instead of filtering documents using `data_stream` properties\r\nwhile the main page was filtering out the documents.\r\n\r\n### Before \r\n\r\n\r\nhttps://github.com/user-attachments/assets/02d14cb9-81a6-4f61-a199-5d1e55443a20\r\n\r\n### After\r\n\r\n\r\nhttps://github.com/user-attachments/assets/09a4e523-b927-4147-99d1-6ceff40f1027","sha":"d26f9ffbb60a7ec6327920ddb520320ed83241d3","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[Dataset quality] 🐞 Rely solely on _index instead of data_stream properties","number":210329,"url":"https://github.com/elastic/kibana/pull/210329","mergeCommit":{"message":"[Dataset quality] 🐞 Rely solely on _index instead of data_stream properties (#210329)\n\nCloses https://github.com/elastic/logs-dev/issues/192.\r\n\r\n## Background\r\n\r\nThis have been an long running issue within dataset quality page which\r\nbecame more noticeable when introducing failure store. Before this\r\nchange `Dataset quality details` page was already solely relying on\r\n`_index` instead of filtering documents using `data_stream` properties\r\nwhile the main page was filtering out the documents.\r\n\r\n### Before \r\n\r\n\r\nhttps://github.com/user-attachments/assets/02d14cb9-81a6-4f61-a199-5d1e55443a20\r\n\r\n### After\r\n\r\n\r\nhttps://github.com/user-attachments/assets/09a4e523-b927-4147-99d1-6ceff40f1027","sha":"d26f9ffbb60a7ec6327920ddb520320ed83241d3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210329","number":210329,"mergeCommit":{"message":"[Dataset quality] 🐞 Rely solely on _index instead of data_stream properties (#210329)\n\nCloses https://github.com/elastic/logs-dev/issues/192.\r\n\r\n## Background\r\n\r\nThis have been an long running issue within dataset quality page which\r\nbecame more noticeable when introducing failure store. Before this\r\nchange `Dataset quality details` page was already solely relying on\r\n`_index` instead of filtering documents using `data_stream` properties\r\nwhile the main page was filtering out the documents.\r\n\r\n### Before \r\n\r\n\r\nhttps://github.com/user-attachments/assets/02d14cb9-81a6-4f61-a199-5d1e55443a20\r\n\r\n### After\r\n\r\n\r\nhttps://github.com/user-attachments/assets/09a4e523-b927-4147-99d1-6ceff40f1027","sha":"d26f9ffbb60a7ec6327920ddb520320ed83241d3"}}]}] BACKPORT--> Co-authored-by: Yngrid Coello <yngrid.coello@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Feb 11, 2025
…m properties (#210329) (#210534) # Backport This will backport the following commits from `main` to `9.0`: - [[Dataset quality] 🐞 Rely solely on _index instead of data_stream properties (#210329)](#210329) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yngrid Coello","email":"yngrid.coello@elastic.co"},"sourceCommit":{"committedDate":"2025-02-11T10:48:45Z","message":"[Dataset quality] 🐞 Rely solely on _index instead of data_stream properties (#210329)\n\nCloses https://github.com/elastic/logs-dev/issues/192.\r\n\r\n## Background\r\n\r\nThis have been an long running issue within dataset quality page which\r\nbecame more noticeable when introducing failure store. Before this\r\nchange `Dataset quality details` page was already solely relying on\r\n`_index` instead of filtering documents using `data_stream` properties\r\nwhile the main page was filtering out the documents.\r\n\r\n### Before \r\n\r\n\r\nhttps://github.com/user-attachments/assets/02d14cb9-81a6-4f61-a199-5d1e55443a20\r\n\r\n### After\r\n\r\n\r\nhttps://github.com/user-attachments/assets/09a4e523-b927-4147-99d1-6ceff40f1027","sha":"d26f9ffbb60a7ec6327920ddb520320ed83241d3","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[Dataset quality] 🐞 Rely solely on _index instead of data_stream properties","number":210329,"url":"https://github.com/elastic/kibana/pull/210329","mergeCommit":{"message":"[Dataset quality] 🐞 Rely solely on _index instead of data_stream properties (#210329)\n\nCloses https://github.com/elastic/logs-dev/issues/192.\r\n\r\n## Background\r\n\r\nThis have been an long running issue within dataset quality page which\r\nbecame more noticeable when introducing failure store. Before this\r\nchange `Dataset quality details` page was already solely relying on\r\n`_index` instead of filtering documents using `data_stream` properties\r\nwhile the main page was filtering out the documents.\r\n\r\n### Before \r\n\r\n\r\nhttps://github.com/user-attachments/assets/02d14cb9-81a6-4f61-a199-5d1e55443a20\r\n\r\n### After\r\n\r\n\r\nhttps://github.com/user-attachments/assets/09a4e523-b927-4147-99d1-6ceff40f1027","sha":"d26f9ffbb60a7ec6327920ddb520320ed83241d3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210329","number":210329,"mergeCommit":{"message":"[Dataset quality] 🐞 Rely solely on _index instead of data_stream properties (#210329)\n\nCloses https://github.com/elastic/logs-dev/issues/192.\r\n\r\n## Background\r\n\r\nThis have been an long running issue within dataset quality page which\r\nbecame more noticeable when introducing failure store. Before this\r\nchange `Dataset quality details` page was already solely relying on\r\n`_index` instead of filtering documents using `data_stream` properties\r\nwhile the main page was filtering out the documents.\r\n\r\n### Before \r\n\r\n\r\nhttps://github.com/user-attachments/assets/02d14cb9-81a6-4f61-a199-5d1e55443a20\r\n\r\n### After\r\n\r\n\r\nhttps://github.com/user-attachments/assets/09a4e523-b927-4147-99d1-6ceff40f1027","sha":"d26f9ffbb60a7ec6327920ddb520320ed83241d3"}}]}] BACKPORT--> Co-authored-by: Yngrid Coello <yngrid.coello@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Feb 11, 2025
…m properties (#210329) (#210533) # Backport This will backport the following commits from `main` to `8.x`: - [[Dataset quality] 🐞 Rely solely on _index instead of data_stream properties (#210329)](#210329) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yngrid Coello","email":"yngrid.coello@elastic.co"},"sourceCommit":{"committedDate":"2025-02-11T10:48:45Z","message":"[Dataset quality] 🐞 Rely solely on _index instead of data_stream properties (#210329)\n\nCloses https://github.com/elastic/logs-dev/issues/192.\r\n\r\n## Background\r\n\r\nThis have been an long running issue within dataset quality page which\r\nbecame more noticeable when introducing failure store. Before this\r\nchange `Dataset quality details` page was already solely relying on\r\n`_index` instead of filtering documents using `data_stream` properties\r\nwhile the main page was filtering out the documents.\r\n\r\n### Before \r\n\r\n\r\nhttps://github.com/user-attachments/assets/02d14cb9-81a6-4f61-a199-5d1e55443a20\r\n\r\n### After\r\n\r\n\r\nhttps://github.com/user-attachments/assets/09a4e523-b927-4147-99d1-6ceff40f1027","sha":"d26f9ffbb60a7ec6327920ddb520320ed83241d3","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[Dataset quality] 🐞 Rely solely on _index instead of data_stream properties","number":210329,"url":"https://github.com/elastic/kibana/pull/210329","mergeCommit":{"message":"[Dataset quality] 🐞 Rely solely on _index instead of data_stream properties (#210329)\n\nCloses https://github.com/elastic/logs-dev/issues/192.\r\n\r\n## Background\r\n\r\nThis have been an long running issue within dataset quality page which\r\nbecame more noticeable when introducing failure store. Before this\r\nchange `Dataset quality details` page was already solely relying on\r\n`_index` instead of filtering documents using `data_stream` properties\r\nwhile the main page was filtering out the documents.\r\n\r\n### Before \r\n\r\n\r\nhttps://github.com/user-attachments/assets/02d14cb9-81a6-4f61-a199-5d1e55443a20\r\n\r\n### After\r\n\r\n\r\nhttps://github.com/user-attachments/assets/09a4e523-b927-4147-99d1-6ceff40f1027","sha":"d26f9ffbb60a7ec6327920ddb520320ed83241d3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210329","number":210329,"mergeCommit":{"message":"[Dataset quality] 🐞 Rely solely on _index instead of data_stream properties (#210329)\n\nCloses https://github.com/elastic/logs-dev/issues/192.\r\n\r\n## Background\r\n\r\nThis have been an long running issue within dataset quality page which\r\nbecame more noticeable when introducing failure store. Before this\r\nchange `Dataset quality details` page was already solely relying on\r\n`_index` instead of filtering documents using `data_stream` properties\r\nwhile the main page was filtering out the documents.\r\n\r\n### Before \r\n\r\n\r\nhttps://github.com/user-attachments/assets/02d14cb9-81a6-4f61-a199-5d1e55443a20\r\n\r\n### After\r\n\r\n\r\nhttps://github.com/user-attachments/assets/09a4e523-b927-4147-99d1-6ceff40f1027","sha":"d26f9ffbb60a7ec6327920ddb520320ed83241d3"}}]}] BACKPORT--> Co-authored-by: Yngrid Coello <yngrid.coello@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/elastic/logs-dev/issues/192.
Background
This have been an long running issue within dataset quality page which became more noticeable when introducing failure store. Before this change
Dataset quality detailspage was already solely relying on_indexinstead of filtering documents usingdata_streamproperties while the main page was filtering out the documents.Before
prev.mov
After
Screen.Recording.2025-02-10.at.12.03.58.mov