Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Obs AI Assistant] Update the simulate function calling setting to support "auto" #209628

Merged
merged 18 commits into from
Feb 7, 2025
Merged

[Obs AI Assistant] Update the simulate function calling setting to support "auto" #209628

merged 18 commits into from
Feb 7, 2025

Conversation

viduni94
Copy link
Contributor

@viduni94 viduni94 commented Feb 4, 2025 •
edited by kibanamachine
Loading

Closes https://github.com/elastic/obs-ai-assistant-team/issues/198

Summary

The simulated function calling setting is currently a boolean. It needs to be updated to support the option auto.
export type FunctionCallingMode = 'native' | 'simulated' | 'auto';

If the setting is set to false, auto will be passed to the inference client. If the setting is true, simulated will be passed to it.

Relates to #208144

Checklist

@viduni94 viduni94 self-assigned this Feb 4, 2025
@viduni94
Copy link
Contributor Author

viduni94 commented Feb 4, 2025

/ci

@viduni94 viduni94 marked this pull request as ready for review February 4, 2025 19:45
@viduni94 viduni94 requested review from a team as code owners February 4, 2025 19:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

@viduni94 viduni94 added v9.0.0 backport:version Backport to applied version labels v8.18.0 labels Feb 4, 2025
@viduni94 viduni94 force-pushed the update-simulated-function-calling-setting branch from d4d3ba2 to bdff547 Compare February 4, 2025 19:46
@viduni94 viduni94 requested a review from pgayvallet February 4, 2025 19:47
sorenlouv
sorenlouv reviewed Feb 4, 2025
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Only suggesting would be getting rid of useSimulatedFunctionCalling entirely if possible.

pgayvallet
pgayvallet approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple questions, and I agree with Soren that ideally, we would totally get rid of the old useSimulatedFunctionCalling: boolean parameter everywhere, but overall looking good, so pre-approving.

src/platform/packages/shared/kbn-management/settings/setting_ids/index.ts Outdated
@@ -137,8 +137,8 @@ export const OBSERVABILITY_LOGS_EXPLORER_ALLOWED_DATA_VIEWS_ID =
export const OBSERVABILITY_LOGS_SHARED_NEW_LOGS_OVERVIEW_ID = 'observability:newLogsOverview';
export const OBSERVABILITY_ENTITY_CENTRIC_EXPERIENCE = 'observability:entityCentricExperience';
export const OBSERVABILITY_LOGS_DATA_ACCESS_LOG_SOURCES_ID = 'observability:logSources';
export const OBSERVABILITY_AI_ASSISTANT_SIMULATED_FUNCTION_CALLING =
'observability:aiAssistantSimulatedFunctionCalling';
export const OBSERVABILITY_AI_ASSISTANT_FUNCTION_CALLING_MODE =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question: with the PR's changes, customers having manually set a value for the old setting key will lost their override.

Are we fine with it or shall we add a SO setting migration?

I think we're overall fine, but want to make sure we thought about it.

Copy link
Member

@sorenlouv sorenlouv Feb 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I also considered this. In the past we have removed settings (like the ability to specify a language for the assistant) and replaced it with something else (user instructions) without migrating. We also did this with the log index pattern.

The impact on users is quite light and the workaround is simple. So while I prefer not "breaking" customers I think in the long run we can provide a better, more bug-free product by keeping things simple and not maintaining strict backwards-compatability.

sabarasaba
sabarasaba approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code owners changes for kbn-management lgtm

@viduni94 viduni94 force-pushed the update-simulated-function-calling-setting branch from bdff547 to 1d7d044 Compare February 5, 2025 13:28
dominiqueclarke
dominiqueclarke approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obs ux management changes LGTM

@elastic elastic deleted a comment from elasticmachine Feb 5, 2025
@viduni94 viduni94 requested a review from sorenlouv February 5, 2025 14:38
@viduni94 viduni94 force-pushed the update-simulated-function-calling-setting branch from 7b11684 to 4576672 Compare February 7, 2025 15:48
@viduni94 viduni94 changed the title [Obs AI Assistant] Update the simulate function calling setting to accept function calling mode [Obs AI Assistant] Update the simulate function calling setting to support "auto" Feb 7, 2025
@viduni94 viduni94 merged commit 343b80a into elastic:main Feb 7, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.18, 8.x, 9.0

https://github.com/elastic/kibana/actions/runs/13208051051

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 7, 2025
@viduni94
[Obs AI Assistant] Update the simulate function calling setting to su…
9cc45a5 
…pport "auto" (elastic#209628)

Closes elastic/obs-ai-assistant-team#198

## Summary

The simulated function calling setting is currently a boolean. It needs
to be updated to support the option `auto`.
`export type FunctionCallingMode = 'native' | 'simulated' | 'auto';`

If the setting is set to `false`, `auto` will be passed to the inference
client. If the setting is `true`, `simulated` will be passed to it.

Relates to elastic#208144

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 343b80a)
@kibanamachine kibanamachine mentioned this pull request Feb 7, 2025
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 7, 2025
@viduni94
[Obs AI Assistant] Update the simulate function calling setting to su…
4af0cbe 
…pport "auto" (elastic#209628)

Closes elastic/obs-ai-assistant-team#198

## Summary

The simulated function calling setting is currently a boolean. It needs
to be updated to support the option `auto`.
`export type FunctionCallingMode = 'native' | 'simulated' | 'auto';`

If the setting is set to `false`, `auto` will be passed to the inference
client. If the setting is `true`, `simulated` will be passed to it.

Relates to elastic#208144

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 343b80a)
@kibanamachine kibanamachine mentioned this pull request Feb 7, 2025
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 7, 2025
@viduni94
[Obs AI Assistant] Update the simulate function calling setting to su…
de9aed0 
…pport "auto" (elastic#209628)

Closes elastic/obs-ai-assistant-team#198

## Summary

The simulated function calling setting is currently a boolean. It needs
to be updated to support the option `auto`.
`export type FunctionCallingMode = 'native' | 'simulated' | 'auto';`

If the setting is set to `false`, `auto` will be passed to the inference
client. If the setting is `true`, `simulated` will be passed to it.

Relates to elastic#208144

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 343b80a)
@kibanamachine kibanamachine mentioned this pull request Feb 7, 2025
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.18
✅ 8.x
✅ 9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 7, 2025
@kibanamachine @viduni94
[9.0] [Obs AI Assistant] Update the simulate function calling setting…
626f393 
… to support &quot;auto&quot; (#209628) (#210278)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[Obs AI Assistant] Update the simulate function calling setting to
support &quot;auto&quot;
(#209628)](#209628)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Viduni
Wickramarachchi","email":"viduni.wickramarachchi@elastic.co"},"sourceCommit":{"committedDate":"2025-02-07T21:07:20Z","message":"[Obs
AI Assistant] Update the simulate function calling setting to support
\"auto\" (#209628)\n\nCloses
https://github.com/elastic/obs-ai-assistant-team/issues/198\n\n##
Summary\n\nThe simulated function calling setting is currently a
boolean. It needs\nto be updated to support the option `auto`.\n`export
type FunctionCallingMode = 'native' | 'simulated' | 'auto';`\n\nIf the
setting is set to `false`, `auto` will be passed to the
inference\nclient. If the setting is `true`, `simulated` will be passed
to it.\n\nRelates to
https://github.com/elastic/kibana/pull/208144\n\n\n### Checklist\n\n-
[x] Any text added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] The PR
description includes the appropriate Release Notes section,\nand the
correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"343b80a8a0bd231791b1b8fc3fb213938b0b1c23","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:Obs
AI
Assistant","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Obs
AI Assistant] Update the simulate function calling setting to support
\"auto\"","number":209628,"url":"https://github.com/elastic/kibana/pull/209628","mergeCommit":{"message":"[Obs
AI Assistant] Update the simulate function calling setting to support
\"auto\" (#209628)\n\nCloses
https://github.com/elastic/obs-ai-assistant-team/issues/198\n\n##
Summary\n\nThe simulated function calling setting is currently a
boolean. It needs\nto be updated to support the option `auto`.\n`export
type FunctionCallingMode = 'native' | 'simulated' | 'auto';`\n\nIf the
setting is set to `false`, `auto` will be passed to the
inference\nclient. If the setting is `true`, `simulated` will be passed
to it.\n\nRelates to
https://github.com/elastic/kibana/pull/208144\n\n\n### Checklist\n\n-
[x] Any text added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] The PR
description includes the appropriate Release Notes section,\nand the
correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"343b80a8a0bd231791b1b8fc3fb213938b0b1c23"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209628","number":209628,"mergeCommit":{"message":"[Obs
AI Assistant] Update the simulate function calling setting to support
\"auto\" (#209628)\n\nCloses
https://github.com/elastic/obs-ai-assistant-team/issues/198\n\n##
Summary\n\nThe simulated function calling setting is currently a
boolean. It needs\nto be updated to support the option `auto`.\n`export
type FunctionCallingMode = 'native' | 'simulated' | 'auto';`\n\nIf the
setting is set to `false`, `auto` will be passed to the
inference\nclient. If the setting is `true`, `simulated` will be passed
to it.\n\nRelates to
https://github.com/elastic/kibana/pull/208144\n\n\n### Checklist\n\n-
[x] Any text added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] The PR
description includes the appropriate Release Notes section,\nand the
correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"343b80a8a0bd231791b1b8fc3fb213938b0b1c23"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Viduni Wickramarachchi <viduni.wickramarachchi@elastic.co>
kibanamachine added a commit that referenced this pull request Feb 7, 2025
@kibanamachine @viduni94
[8.18] [Obs AI Assistant] Update the simulate function calling settin…
083e103 
…g to support &quot;auto&quot; (#209628) (#210276)

# Backport

This will backport the following commits from `main` to `8.18`:
- [[Obs AI Assistant] Update the simulate function calling setting to
support &quot;auto&quot;
(#209628)](#209628)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Viduni
Wickramarachchi","email":"viduni.wickramarachchi@elastic.co"},"sourceCommit":{"committedDate":"2025-02-07T21:07:20Z","message":"[Obs
AI Assistant] Update the simulate function calling setting to support
\"auto\" (#209628)\n\nCloses
https://github.com/elastic/obs-ai-assistant-team/issues/198\n\n##
Summary\n\nThe simulated function calling setting is currently a
boolean. It needs\nto be updated to support the option `auto`.\n`export
type FunctionCallingMode = 'native' | 'simulated' | 'auto';`\n\nIf the
setting is set to `false`, `auto` will be passed to the
inference\nclient. If the setting is `true`, `simulated` will be passed
to it.\n\nRelates to
https://github.com/elastic/kibana/pull/208144\n\n\n### Checklist\n\n-
[x] Any text added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] The PR
description includes the appropriate Release Notes section,\nand the
correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"343b80a8a0bd231791b1b8fc3fb213938b0b1c23","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:Obs
AI
Assistant","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Obs
AI Assistant] Update the simulate function calling setting to support
\"auto\"","number":209628,"url":"https://github.com/elastic/kibana/pull/209628","mergeCommit":{"message":"[Obs
AI Assistant] Update the simulate function calling setting to support
\"auto\" (#209628)\n\nCloses
https://github.com/elastic/obs-ai-assistant-team/issues/198\n\n##
Summary\n\nThe simulated function calling setting is currently a
boolean. It needs\nto be updated to support the option `auto`.\n`export
type FunctionCallingMode = 'native' | 'simulated' | 'auto';`\n\nIf the
setting is set to `false`, `auto` will be passed to the
inference\nclient. If the setting is `true`, `simulated` will be passed
to it.\n\nRelates to
https://github.com/elastic/kibana/pull/208144\n\n\n### Checklist\n\n-
[x] Any text added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] The PR
description includes the appropriate Release Notes section,\nand the
correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"343b80a8a0bd231791b1b8fc3fb213938b0b1c23"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209628","number":209628,"mergeCommit":{"message":"[Obs
AI Assistant] Update the simulate function calling setting to support
\"auto\" (#209628)\n\nCloses
https://github.com/elastic/obs-ai-assistant-team/issues/198\n\n##
Summary\n\nThe simulated function calling setting is currently a
boolean. It needs\nto be updated to support the option `auto`.\n`export
type FunctionCallingMode = 'native' | 'simulated' | 'auto';`\n\nIf the
setting is set to `false`, `auto` will be passed to the
inference\nclient. If the setting is `true`, `simulated` will be passed
to it.\n\nRelates to
https://github.com/elastic/kibana/pull/208144\n\n\n### Checklist\n\n-
[x] Any text added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] The PR
description includes the appropriate Release Notes section,\nand the
correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"343b80a8a0bd231791b1b8fc3fb213938b0b1c23"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Viduni Wickramarachchi <viduni.wickramarachchi@elastic.co>
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Feb 10, 2025
@viduni94 @kibanamachine @Samiul-TheSoccerFan
[Obs AI Assistant] Update the simulate function calling setting to su…
3835737 
…pport "auto" (elastic#209628)

Closes elastic/obs-ai-assistant-team#198

## Summary

The simulated function calling setting is currently a boolean. It needs
to be updated to support the option `auto`.
`export type FunctionCallingMode = 'native' | 'simulated' | 'auto';`

If the setting is set to `false`, `auto` will be passed to the inference
client. If the setting is `true`, `simulated` will be passed to it.

Relates to elastic#208144


### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 11, 2025
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

viduni94 added a commit to kibanamachine/kibana that referenced this pull request Feb 12, 2025
@viduni94
[Obs AI Assistant] Update the simulate function calling setting to su…
713c6f3 
…pport "auto" (elastic#209628)

Closes elastic/obs-ai-assistant-team#198

## Summary

The simulated function calling setting is currently a boolean. It needs
to be updated to support the option `auto`.
`export type FunctionCallingMode = 'native' | 'simulated' | 'auto';`

If the setting is set to `false`, `auto` will be passed to the inference
client. If the setting is `true`, `simulated` will be passed to it.

Relates to elastic#208144

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 343b80a)
kibanamachine added a commit that referenced this pull request Feb 13, 2025
@kibanamachine @viduni94
[8.x] [Obs AI Assistant] Update the simulate function calling setting…
b8c2230 
… to support &quot;auto&quot; (#209628) (#210277)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Obs AI Assistant] Update the simulate function calling setting to
support &quot;auto&quot;
(#209628)](#209628)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Viduni
Wickramarachchi","email":"viduni.wickramarachchi@elastic.co"},"sourceCommit":{"committedDate":"2025-02-07T21:07:20Z","message":"[Obs
AI Assistant] Update the simulate function calling setting to support
\"auto\" (#209628)\n\nCloses
https://github.com/elastic/obs-ai-assistant-team/issues/198\n\n##
Summary\n\nThe simulated function calling setting is currently a
boolean. It needs\nto be updated to support the option `auto`.\n`export
type FunctionCallingMode = 'native' | 'simulated' | 'auto';`\n\nIf the
setting is set to `false`, `auto` will be passed to the
inference\nclient. If the setting is `true`, `simulated` will be passed
to it.\n\nRelates to
https://github.com/elastic/kibana/pull/208144\n\n\n### Checklist\n\n-
[x] Any text added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] The PR
description includes the appropriate Release Notes section,\nand the
correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"343b80a8a0bd231791b1b8fc3fb213938b0b1c23","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:Obs
AI
Assistant","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Obs
AI Assistant] Update the simulate function calling setting to support
\"auto\"","number":209628,"url":"https://github.com/elastic/kibana/pull/209628","mergeCommit":{"message":"[Obs
AI Assistant] Update the simulate function calling setting to support
\"auto\" (#209628)\n\nCloses
https://github.com/elastic/obs-ai-assistant-team/issues/198\n\n##
Summary\n\nThe simulated function calling setting is currently a
boolean. It needs\nto be updated to support the option `auto`.\n`export
type FunctionCallingMode = 'native' | 'simulated' | 'auto';`\n\nIf the
setting is set to `false`, `auto` will be passed to the
inference\nclient. If the setting is `true`, `simulated` will be passed
to it.\n\nRelates to
https://github.com/elastic/kibana/pull/208144\n\n\n### Checklist\n\n-
[x] Any text added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] The PR
description includes the appropriate Release Notes section,\nand the
correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"343b80a8a0bd231791b1b8fc3fb213938b0b1c23"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209628","number":209628,"mergeCommit":{"message":"[Obs
AI Assistant] Update the simulate function calling setting to support
\"auto\" (#209628)\n\nCloses
https://github.com/elastic/obs-ai-assistant-team/issues/198\n\n##
Summary\n\nThe simulated function calling setting is currently a
boolean. It needs\nto be updated to support the option `auto`.\n`export
type FunctionCallingMode = 'native' | 'simulated' | 'auto';`\n\nIf the
setting is set to `false`, `auto` will be passed to the
inference\nclient. If the setting is `true`, `simulated` will be passed
to it.\n\nRelates to
https://github.com/elastic/kibana/pull/208144\n\n\n### Checklist\n\n-
[x] Any text added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] The PR
description includes the appropriate Release Notes section,\nand the
correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"343b80a8a0bd231791b1b8fc3fb213938b0b1c23"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Viduni Wickramarachchi <viduni.wickramarachchi@elastic.co>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@sabarasaba sabarasaba sabarasaba approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@jloleysens jloleysens jloleysens approved these changes

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

@sphilipse sphilipse sphilipse approved these changes

Assignees

@viduni94 viduni94

Labels
backport:version Backport to applied version labels release_note:fix Team:Obs AI Assistant Observability AI Assistant v8.18.0 v8.19.0 v9.0.0 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@viduni94 @elasticmachine @kibanamachine @sorenlouv @sabarasaba @pgayvallet @jloleysens @dominiqueclarke @sphilipse