[Security Solutions] Update cell actions copy #209436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c4df8c6 to
8b1709c
Compare
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
lgmys
approved these changes
Feb 4, 2025
lgestc
approved these changes
Feb 4, 2025
semd
approved these changes
Feb 4, 2025
PhilippeOberti
requested changes
Feb 4, 2025
PhilippeOberti
approved these changes
Feb 4, 2025
|
Changes look good - thanks, @christineweng! |
nastasha-solomon
approved these changes
Feb 5, 2025
430de01 to
7efea6c
Compare
5c34dca to
d045a7c
Compare
ashokaditya
approved these changes
Feb 10, 2025
paul-tavares
approved these changes
Feb 10, 2025
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
|
Starting backport for target branches: 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/13249076933 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 10, 2025
## Summary This is a part 2 following elastic#206340 to standardize actions in the alerts kpi visualizations. This PR updates the following copies: - Changed `Filter In` to `Filter for`: to stay consistent with Lens and Discover <img width="1070" alt="image" src="https://github.com/user-attachments/assets/3341279f-7e8f-4470-9476-86809840ff55" /> - Updated letter cases by following copy guidelines - `Filter Out` -> `Filter out` - `Copy to Clipboard` -> `Copy to clipboard` - `Investigate in timeline` -> `Investigate in Timeline` - `Add to timeline` -> `Add to Timeline` ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit d2c5132)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 10, 2025
## Summary This is a part 2 following elastic#206340 to standardize actions in the alerts kpi visualizations. This PR updates the following copies: - Changed `Filter In` to `Filter for`: to stay consistent with Lens and Discover <img width="1070" alt="image" src="https://github.com/user-attachments/assets/3341279f-7e8f-4470-9476-86809840ff55" /> - Updated letter cases by following copy guidelines - `Filter Out` -> `Filter out` - `Copy to Clipboard` -> `Copy to clipboard` - `Investigate in timeline` -> `Investigate in Timeline` - `Add to timeline` -> `Add to Timeline` ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit d2c5132)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 10, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[Security Solutions] Update cell actions copy (#209436)](#209436) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"18648970+christineweng@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-10T19:41:07Z","message":"[Security Solutions] Update cell actions copy (#209436)\n\n## Summary\r\n\r\nThis is a part 2 following https://github.com/elastic/kibana/pull/206340\r\nto standardize actions in the alerts kpi visualizations.\r\n\r\nThis PR updates the following copies:\r\n- Changed `Filter In` to `Filter for`: to stay consistent with Lens and\r\nDiscover\r\n<img width=\"1070\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/3341279f-7e8f-4470-9476-86809840ff55\"\r\n/>\r\n\r\n- Updated letter cases by following copy guidelines\r\n - `Filter Out` -> `Filter out` \r\n - `Copy to Clipboard` -> `Copy to clipboard`\r\n - `Investigate in timeline` -> `Investigate in Timeline`\r\n - `Add to timeline` -> `Add to Timeline`\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This was checked for breaking HTTP API changes, and any breaking\r\nchanges have been approved by the breaking-change committee. The\r\n`release_note:breaking` label should be applied in these situations.\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"d2c5132f7423a15f9c2f9cf3e60c95ec50174235","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","Team:Threat Hunting","Team:Threat Hunting:Investigations","v9.1.0","v8.19.0"],"title":"[Security Solutions] Update cell actions copy","number":209436,"url":"https://github.com/elastic/kibana/pull/209436","mergeCommit":{"message":"[Security Solutions] Update cell actions copy (#209436)\n\n## Summary\r\n\r\nThis is a part 2 following https://github.com/elastic/kibana/pull/206340\r\nto standardize actions in the alerts kpi visualizations.\r\n\r\nThis PR updates the following copies:\r\n- Changed `Filter In` to `Filter for`: to stay consistent with Lens and\r\nDiscover\r\n<img width=\"1070\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/3341279f-7e8f-4470-9476-86809840ff55\"\r\n/>\r\n\r\n- Updated letter cases by following copy guidelines\r\n - `Filter Out` -> `Filter out` \r\n - `Copy to Clipboard` -> `Copy to clipboard`\r\n - `Investigate in timeline` -> `Investigate in Timeline`\r\n - `Add to timeline` -> `Add to Timeline`\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This was checked for breaking HTTP API changes, and any breaking\r\nchanges have been approved by the breaking-change committee. The\r\n`release_note:breaking` label should be applied in these situations.\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"d2c5132f7423a15f9c2f9cf3e60c95ec50174235"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209436","number":209436,"mergeCommit":{"message":"[Security Solutions] Update cell actions copy (#209436)\n\n## Summary\r\n\r\nThis is a part 2 following https://github.com/elastic/kibana/pull/206340\r\nto standardize actions in the alerts kpi visualizations.\r\n\r\nThis PR updates the following copies:\r\n- Changed `Filter In` to `Filter for`: to stay consistent with Lens and\r\nDiscover\r\n<img width=\"1070\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/3341279f-7e8f-4470-9476-86809840ff55\"\r\n/>\r\n\r\n- Updated letter cases by following copy guidelines\r\n - `Filter Out` -> `Filter out` \r\n - `Copy to Clipboard` -> `Copy to clipboard`\r\n - `Investigate in timeline` -> `Investigate in Timeline`\r\n - `Add to timeline` -> `Add to Timeline`\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This was checked for breaking HTTP API changes, and any breaking\r\nchanges have been approved by the breaking-change committee. The\r\n`release_note:breaking` label should be applied in these situations.\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"d2c5132f7423a15f9c2f9cf3e60c95ec50174235"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: christineweng <18648970+christineweng@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a part 2 following #206340 to standardize actions in the alerts kpi visualizations.
This PR updates the following copies:
Filter IntoFilter for: to stay consistent with Lens and DiscoverFilter Out->Filter outCopy to Clipboard->Copy to clipboardInvestigate in timeline->Investigate in TimelineAdd to timeline->Add to TimelineChecklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelines