[8.16] [Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule (#209133) #209287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cution for the custom threshold rule (elastic#209133) Fixes elastic#200772 ## 🐉 Summary This PR fixes supporting data view runtime fields during rule execution for the custom threshold rule. ## 🧪 How to test 1. Create a runtime field as shown below: |Runtime field| Preview| |---|---| ||| 2. Make sure alerts are generated as expected both for regular and no-data alerts:  ### TODO - [x] Add an API integration test - [x] Test on MKI (cherry picked from commit 8fe5738) # Conflicts: # x-pack/plugins/observability_solution/observability/server/lib/rules/custom_threshold/lib/is_populated_object.test.ts # x-pack/plugins/observability_solution/observability/server/lib/rules/custom_threshold/lib/is_populated_object.ts # x-pack/test/api_integration/deployment_agnostic/services/data_view_api.ts # x-pack/test_serverless/api_integration/test_suites/observability/custom_threshold_rule/cardinality_runtime_field_fired.ts # x-pack/test_serverless/api_integration/test_suites/observability/custom_threshold_rule/index.ts
2 tasks
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
⏳ Build in-progress
History
|
shahzad31
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.16:Questions ?
Please refer to the Backport tool documentation