Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.17] [Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule (#209133) #209280

Merged
merged 2 commits into from
Feb 4, 2025
Merged

[8.17] [Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule (#209133) #209280

merged 2 commits into from
Feb 4, 2025

Conversation

maryam-saeidi
Copy link
Member

Backport

This will backport the following commits from main to 8.17:

Questions ?

Please refer to the Backport tool documentation

@maryam-saeidi
[Custom threshold] Fix using data view runtime fields during rule exe…
77d14e7 
…cution for the custom threshold rule (elastic#209133)

Fixes elastic#200772

## 🐉  Summary

This PR fixes supporting data view runtime fields during rule execution
for the custom threshold rule.

## 🧪 How to test

1. Create a runtime field as shown below:

    |Runtime field| Preview|
    |---|---|

|![Image](https://github.com/user-attachments/assets/09fc0754-8944-486e-bf85-10b3f3464d17)|![Image](https://github.com/user-attachments/assets/e93efad5-bc3b-4306-b820-8b096dbba360)|

2. Make sure alerts are generated as expected both for regular and
no-data alerts:

![image](https://github.com/user-attachments/assets/a2174e40-11a4-4d75-8500-bfce126ba7cd)

### TODO
- [x] Add an API integration test
    - [x] Test on MKI

(cherry picked from commit 8fe5738)

# Conflicts:
#	x-pack/plugins/observability_solution/observability/server/lib/rules/custom_threshold/lib/is_populated_object.test.ts
#	x-pack/plugins/observability_solution/observability/server/lib/rules/custom_threshold/lib/is_populated_object.ts
@maryam-saeidi maryam-saeidi enabled auto-merge (squash) February 3, 2025 13:14
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Feb 3, 2025
@maryam-saeidi maryam-saeidi mentioned this pull request Feb 3, 2025
Merged
2 tasks
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 4, 2025 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: d0ccc23
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-209280-d0ccc2324594

Metrics [docs]

✅ unchanged

History

@maryam-saeidi maryam-saeidi merged commit 732ea4f into elastic:8.17 Feb 4, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees
No one assigned
Labels
backport ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maryam-saeidi @elasticmachine @shahzad31