-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs] Manual migration for routes with access tags #208484
[Logs] Manual migration for routes with access tags #208484
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
// Currently we have no use of custom options beyond tags, this can be extended | ||
// beyond defaultOptions if it's needed. | ||
options: defaultOptions, | ||
security: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/13017187798 |
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
History
cc @yngrdyn |
Relates to elastic/kibana-team#1235. --- ## Team: `@elastic/obs-ux-logs-team` | URL | PR | | --- | --- | | `/api/log_entries/highlights` | current PR | | `/api/log_entries/summary` | current PR | | `/api/log_entries/summary_highlights` | current PR | | `/api/infra/log_views/{logViewId}` | elastic#204214 | | `/api/infra/log_views/{logViewId}` | elastic#204214 | | `/api/infra/log_analysis/results/log_entry_categories` | elastic#204214 | | `/api/infra/log_analysis/results/log_entry_category_datasets` | elastic#204214 | | `/api/infra/log_analysis/results/latest_log_entry_category_datasets_stats` | elastic#204214 | | `/api/infra/log_analysis/results/log_entry_category_examples` | elastic#204214 | | `/api/infra/log_analysis/results/log_entry_anomalies` | elastic#204214 | | `/api/infra/log_analysis/results/log_entry_anomalies_datasets` | elastic#204214 | | `/api/infra/log_analysis/id_formats` | elastic#204214 | | `/api/infra/log_analysis/validation/log_entry_datasets` | elastic#204214 | | `/api/infra/log_analysis/validation/log_entry_rate_indices` | elastic#204214 | | `/api/infra/log_analysis/results/log_entry_examples` | elastic#204214 | | `/api/infra/log_alerts/chart_preview_data` | elastic#204214 | (cherry picked from commit 013a124)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…208598) # Backport This will backport the following commits from `main` to `8.x`: - [[Logs] Manual migration for routes with access tags (#208484)](#208484) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yngrid Coello","email":"yngrid.coello@elastic.co"},"sourceCommit":{"committedDate":"2025-01-28T18:34:05Z","message":"[Logs] Manual migration for routes with access tags (#208484)\n\nRelates to https://github.com/elastic/kibana-team/issues/1235.\r\n\r\n---\r\n## Team: `@elastic/obs-ux-logs-team`\r\n\r\n| URL | PR |\r\n| --- | --- |\r\n| `/api/log_entries/highlights` | current PR |\r\n| `/api/log_entries/summary` | current PR |\r\n| `/api/log_entries/summary_highlights` | current PR |\r\n| `/api/infra/log_views/{logViewId}` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_views/{logViewId}` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_analysis/results/log_entry_categories` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_analysis/results/log_entry_category_datasets` |\r\nhttps://github.com//pull/204214 |\r\n|\r\n`/api/infra/log_analysis/results/latest_log_entry_category_datasets_stats`\r\n| #204214 |\r\n| `/api/infra/log_analysis/results/log_entry_category_examples` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_analysis/results/log_entry_anomalies` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_analysis/results/log_entry_anomalies_datasets` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_analysis/id_formats` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_analysis/validation/log_entry_datasets` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_analysis/validation/log_entry_rate_indices` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_analysis/results/log_entry_examples` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_alerts/chart_preview_data` |\r\nhttps://github.com//pull/204214 |","sha":"013a1248a3338144799e4dc32ffc4bec9aa5b9f8","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"[Logs] Manual migration for routes with access tags","number":208484,"url":"https://github.com/elastic/kibana/pull/208484","mergeCommit":{"message":"[Logs] Manual migration for routes with access tags (#208484)\n\nRelates to https://github.com/elastic/kibana-team/issues/1235.\r\n\r\n---\r\n## Team: `@elastic/obs-ux-logs-team`\r\n\r\n| URL | PR |\r\n| --- | --- |\r\n| `/api/log_entries/highlights` | current PR |\r\n| `/api/log_entries/summary` | current PR |\r\n| `/api/log_entries/summary_highlights` | current PR |\r\n| `/api/infra/log_views/{logViewId}` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_views/{logViewId}` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_analysis/results/log_entry_categories` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_analysis/results/log_entry_category_datasets` |\r\nhttps://github.com//pull/204214 |\r\n|\r\n`/api/infra/log_analysis/results/latest_log_entry_category_datasets_stats`\r\n| #204214 |\r\n| `/api/infra/log_analysis/results/log_entry_category_examples` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_analysis/results/log_entry_anomalies` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_analysis/results/log_entry_anomalies_datasets` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_analysis/id_formats` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_analysis/validation/log_entry_datasets` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_analysis/validation/log_entry_rate_indices` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_analysis/results/log_entry_examples` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_alerts/chart_preview_data` |\r\nhttps://github.com//pull/204214 |","sha":"013a1248a3338144799e4dc32ffc4bec9aa5b9f8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208484","number":208484,"mergeCommit":{"message":"[Logs] Manual migration for routes with access tags (#208484)\n\nRelates to https://github.com/elastic/kibana-team/issues/1235.\r\n\r\n---\r\n## Team: `@elastic/obs-ux-logs-team`\r\n\r\n| URL | PR |\r\n| --- | --- |\r\n| `/api/log_entries/highlights` | current PR |\r\n| `/api/log_entries/summary` | current PR |\r\n| `/api/log_entries/summary_highlights` | current PR |\r\n| `/api/infra/log_views/{logViewId}` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_views/{logViewId}` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_analysis/results/log_entry_categories` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_analysis/results/log_entry_category_datasets` |\r\nhttps://github.com//pull/204214 |\r\n|\r\n`/api/infra/log_analysis/results/latest_log_entry_category_datasets_stats`\r\n| #204214 |\r\n| `/api/infra/log_analysis/results/log_entry_category_examples` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_analysis/results/log_entry_anomalies` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_analysis/results/log_entry_anomalies_datasets` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_analysis/id_formats` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_analysis/validation/log_entry_datasets` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_analysis/validation/log_entry_rate_indices` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_analysis/results/log_entry_examples` |\r\nhttps://github.com//pull/204214 |\r\n| `/api/infra/log_alerts/chart_preview_data` |\r\nhttps://github.com//pull/204214 |","sha":"013a1248a3338144799e4dc32ffc4bec9aa5b9f8"}}]}] BACKPORT--> Co-authored-by: Yngrid Coello <yngrid.coello@elastic.co>
Relates to https://github.com/elastic/kibana-team/issues/1235.
Team:
@elastic/obs-ux-logs-team
/api/log_entries/highlights
/api/log_entries/summary
/api/log_entries/summary_highlights
/api/infra/log_views/{logViewId}
/api/infra/log_views/{logViewId}
/api/infra/log_analysis/results/log_entry_categories
/api/infra/log_analysis/results/log_entry_category_datasets
/api/infra/log_analysis/results/latest_log_entry_category_datasets_stats
/api/infra/log_analysis/results/log_entry_category_examples
/api/infra/log_analysis/results/log_entry_anomalies
/api/infra/log_analysis/results/log_entry_anomalies_datasets
/api/infra/log_analysis/id_formats
/api/infra/log_analysis/validation/log_entry_datasets
/api/infra/log_analysis/validation/log_entry_rate_indices
/api/infra/log_analysis/results/log_entry_examples
/api/infra/log_alerts/chart_preview_data