[React@18] fix When on the host isolation exceptions page should search using expected exception item fields #208396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History |
ashokaditya
approved these changes
Jan 28, 2025
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/13015071168 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 28, 2025
…ch using expected exception item fields (elastic#208396) ## Summary fix elastic#208339 (comment) - [ ] [[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-264a-4056-8026-2be65f9e16b9) [[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-264a-4056-8026-2be65f9e16b9/artifacts/0194a7ad-2ab6-40c2-a11c-685683bbb663) Jest Integration Tests / When on the host isolation exceptions page should search using expected exception item fields Fix the test so it passes with React@18 ``` REACT_18=true node scripts/jest --config=x-pack/solutions/security/plugins/security_solution/jest.integration.config.js /x-pack/solutions/security/plugins/security_solution/public/management/pages/host_isolation_exceptions/view/integration_tests/host_isolation_exceptions_list.test.tsx ``` We already saw a very similar timeout failure here: https://github.com/elastic/kibana/pull/207195/files#r1922454027 (cherry picked from commit 8f10ac2)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 28, 2025
…d search using expected exception item fields (#208396) (#208574) # Backport This will backport the following commits from `main` to `8.x`: - [[React@18] fix When on the host isolation exceptions page should search using expected exception item fields (#208396)](#208396) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Anton Dosov","email":"anton.dosov@elastic.co"},"sourceCommit":{"committedDate":"2025-01-28T16:32:02Z","message":"[React@18] fix When on the host isolation exceptions page should search using expected exception item fields (#208396)\n\n## Summary\r\n\r\nfix\r\nhttps://github.com//pull/208339#issuecomment-2615621371\r\n\r\n- [ ]\r\n[[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-264a-4056-8026-2be65f9e16b9)\r\n[[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-264a-4056-8026-2be65f9e16b9/artifacts/0194a7ad-2ab6-40c2-a11c-685683bbb663)\r\nJest Integration Tests / When on the host isolation exceptions page\r\nshould search using expected exception item fields\r\n\r\n\r\nFix the test so it passes with React@18\r\n\r\n\r\n```\r\nREACT_18=true node scripts/jest --config=x-pack/solutions/security/plugins/security_solution/jest.integration.config.js /x-pack/solutions/security/plugins/security_solution/public/management/pages/host_isolation_exceptions/view/integration_tests/host_isolation_exceptions_list.test.tsx\r\n```\r\n\r\n\r\nWe already saw a very similar timeout failure here:\r\nhttps://github.com//pull/207195/files#r1922454027","sha":"8f10ac2163de398e8d22a0d14a5cbe99ccc951fa","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor","React@18"],"title":"[React@18] fix When on the host isolation exceptions page should search using expected exception item fields","number":208396,"url":"https://github.com/elastic/kibana/pull/208396","mergeCommit":{"message":"[React@18] fix When on the host isolation exceptions page should search using expected exception item fields (#208396)\n\n## Summary\r\n\r\nfix\r\nhttps://github.com//pull/208339#issuecomment-2615621371\r\n\r\n- [ ]\r\n[[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-264a-4056-8026-2be65f9e16b9)\r\n[[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-264a-4056-8026-2be65f9e16b9/artifacts/0194a7ad-2ab6-40c2-a11c-685683bbb663)\r\nJest Integration Tests / When on the host isolation exceptions page\r\nshould search using expected exception item fields\r\n\r\n\r\nFix the test so it passes with React@18\r\n\r\n\r\n```\r\nREACT_18=true node scripts/jest --config=x-pack/solutions/security/plugins/security_solution/jest.integration.config.js /x-pack/solutions/security/plugins/security_solution/public/management/pages/host_isolation_exceptions/view/integration_tests/host_isolation_exceptions_list.test.tsx\r\n```\r\n\r\n\r\nWe already saw a very similar timeout failure here:\r\nhttps://github.com//pull/207195/files#r1922454027","sha":"8f10ac2163de398e8d22a0d14a5cbe99ccc951fa"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208396","number":208396,"mergeCommit":{"message":"[React@18] fix When on the host isolation exceptions page should search using expected exception item fields (#208396)\n\n## Summary\r\n\r\nfix\r\nhttps://github.com//pull/208339#issuecomment-2615621371\r\n\r\n- [ ]\r\n[[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-264a-4056-8026-2be65f9e16b9)\r\n[[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-264a-4056-8026-2be65f9e16b9/artifacts/0194a7ad-2ab6-40c2-a11c-685683bbb663)\r\nJest Integration Tests / When on the host isolation exceptions page\r\nshould search using expected exception item fields\r\n\r\n\r\nFix the test so it passes with React@18\r\n\r\n\r\n```\r\nREACT_18=true node scripts/jest --config=x-pack/solutions/security/plugins/security_solution/jest.integration.config.js /x-pack/solutions/security/plugins/security_solution/public/management/pages/host_isolation_exceptions/view/integration_tests/host_isolation_exceptions_list.test.tsx\r\n```\r\n\r\n\r\nWe already saw a very similar timeout failure here:\r\nhttps://github.com//pull/207195/files#r1922454027","sha":"8f10ac2163de398e8d22a0d14a5cbe99ccc951fa"}}]}] BACKPORT--> Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #208339 (comment)
Fix the test so it passes with React@18
We already saw a very similar timeout failure here: https://github.com/elastic/kibana/pull/207195/files#r1922454027