[CI] Cloud purge: improve logging, add CLOUD_DELETE_ON_ERROR #208392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Jan 27, 2025
💚 Build Succeeded
Metrics [docs]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When not run through the official way, cloud deployments can get weird names (e.g.:
kibana-pr-false- from incorrect parameterization through testing: https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/192).This throws a wrench in the gears for the purge script. Although the removals still work, the script exits with status code 1, which fails the pipeline.
This PR adds some more resilience to the script, better logging of problematic cases, and a flag to allow removal of problematic cases (if someone manually runs the pipeline with
CLOUD_DELETE_ON_ERROR=1).Tested:
keep_...instance, but never again?)+e, and exit code comparison https://buildkite.com/elastic/kibana-purge-cloud-deployments/builds/6713