[Security Assistant] Fix Knowledge Base index entry form #208268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
|
/ci |
…bana into fix/index-entry-form
|
/ci |
|
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
e40pud
approved these changes
Jan 28, 2025
| if (value.type === 'semantic_text') { | ||
| paths.push( | ||
| newPath.filter( | ||
| (pathPart) => pathPart !== 'properties' && pathPart !== 'mappings' |
There was a problem hiding this comment.
are properties and mappings both reserved names and never can be field names?
| let paths: string[][] = []; | ||
|
|
||
| for (const key in obj) { | ||
| if (Object.prototype.hasOwnProperty.call(obj, key)) { |
There was a problem hiding this comment.
Just curious why we need to do Object.prototype.hasOwnProperty check here and at line 105
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/13016463867 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 28, 2025
) ## Summary Fix showing indices with `semantic_text` fields in Knowledge Base Index entry form <img width="1751" alt="Zrzut ekranu 2025-01-27 o 20 43 43" src="https://github.com/user-attachments/assets/f4cb0364-3228-4909-84be-a5bcca00943a" /> <img width="1751" alt="Zrzut ekranu 2025-01-27 o 20 43 43" src="https://github.com/user-attachments/assets/02d80c11-f40b-4ac7-8906-2f11ab75f20d" /> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 590b4c7)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 28, 2025
…) (#208589) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Assistant] Fix Knowledge Base index entry form (#208268)](#208268) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Patryk Kopyciński","email":"contact@patrykkopycinski.com"},"sourceCommit":{"committedDate":"2025-01-28T17:50:31Z","message":"[Security Assistant] Fix Knowledge Base index entry form (#208268)\n\n## Summary\r\n\r\nFix showing indices with `semantic_text` fields in Knowledge Base Index\r\nentry form\r\n\r\n<img width=\"1751\" alt=\"Zrzut ekranu 2025-01-27 o 20 43 43\"\r\nsrc=\"https://github.com/user-attachments/assets/f4cb0364-3228-4909-84be-a5bcca00943a\"\r\n/>\r\n\r\n<img width=\"1751\" alt=\"Zrzut ekranu 2025-01-27 o 20 43 43\"\r\nsrc=\"https://github.com/user-attachments/assets/02d80c11-f40b-4ac7-8906-2f11ab75f20d\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"590b4c7fb1123e6241243c6fb6a13aec4073fcd8","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Feature:Security Assistant","Team:Security Generative AI","backport:version","v8.18.0"],"title":"[Security Assistant] Fix Knowledge Base index entry form","number":208268,"url":"https://github.com/elastic/kibana/pull/208268","mergeCommit":{"message":"[Security Assistant] Fix Knowledge Base index entry form (#208268)\n\n## Summary\r\n\r\nFix showing indices with `semantic_text` fields in Knowledge Base Index\r\nentry form\r\n\r\n<img width=\"1751\" alt=\"Zrzut ekranu 2025-01-27 o 20 43 43\"\r\nsrc=\"https://github.com/user-attachments/assets/f4cb0364-3228-4909-84be-a5bcca00943a\"\r\n/>\r\n\r\n<img width=\"1751\" alt=\"Zrzut ekranu 2025-01-27 o 20 43 43\"\r\nsrc=\"https://github.com/user-attachments/assets/02d80c11-f40b-4ac7-8906-2f11ab75f20d\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"590b4c7fb1123e6241243c6fb6a13aec4073fcd8"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208268","number":208268,"mergeCommit":{"message":"[Security Assistant] Fix Knowledge Base index entry form (#208268)\n\n## Summary\r\n\r\nFix showing indices with `semantic_text` fields in Knowledge Base Index\r\nentry form\r\n\r\n<img width=\"1751\" alt=\"Zrzut ekranu 2025-01-27 o 20 43 43\"\r\nsrc=\"https://github.com/user-attachments/assets/f4cb0364-3228-4909-84be-a5bcca00943a\"\r\n/>\r\n\r\n<img width=\"1751\" alt=\"Zrzut ekranu 2025-01-27 o 20 43 43\"\r\nsrc=\"https://github.com/user-attachments/assets/02d80c11-f40b-4ac7-8906-2f11ab75f20d\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"590b4c7fb1123e6241243c6fb6a13aec4073fcd8"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix showing indices with
semantic_textfields in Knowledge Base Index entry form