Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kbn-grid-layout] Make drag preview absolute positioned #208247

Merged
merged 1 commit into from
Jan 24, 2025
Merged

[kbn-grid-layout] Make drag preview absolute positioned #208247

merged 1 commit into from
Jan 24, 2025
+6 −4

Conversation

Heenawter
Copy link
Contributor

@Heenawter Heenawter commented Jan 24, 2025 •
edited by kibanamachine
Loading

Summary

This PR positions the drag preview via absolute positioning. This is a potential fix for EuiResizeObservers being fired unnecessarily.

Checklist

  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

@Heenawter Heenawter added bug Fixes for quality problems that affect the customer experience release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Project:Collapsable Panels Related to the project for adding collapsable sections to Dashboards. labels Jan 24, 2025
@Heenawter Heenawter self-assigned this Jan 24, 2025
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 623.0KB 623.4KB +314.0B

cc @Heenawter

@Heenawter Heenawter marked this pull request as ready for review January 24, 2025 19:33
@Heenawter Heenawter requested a review from a team as a code owner January 24, 2025 19:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@Heenawter Heenawter added the backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) label Jan 24, 2025
ThomThomson
ThomThomson approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM! Merging should be dependent on whether or not we can verify locally that this fixes the problem.

@Heenawter
Copy link
Contributor Author

Verified that this does indeed seem to fix the issue:

Before After
image image

@Heenawter Heenawter merged commit 1ff451a into elastic:main Jan 24, 2025
23 checks passed
@Heenawter Heenawter deleted the kbn-grid-layout_fix-drag-preview_2025-01-24 branch January 24, 2025 21:43
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12958112584

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 24, 2025
@Heenawter
[kbn-grid-layout] Make drag preview absolute positioned (elastic#20…
5a6d1e8 
…8247)

## Summary

This PR positions the drag preview via `absolute` positioning. This is a
potential fix for `EuiResizeObservers` being fired unnecessarily.

### Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 1ff451a)
@kibanamachine kibanamachine mentioned this pull request Jan 24, 2025
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 24, 2025
@kibanamachine @Heenawter
[8.x] [`kbn-grid-layout`] Make drag preview absolute positi…
b3c3a8c 
…oned (#208247) (#208278)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[`kbn-grid-layout`] Make drag preview absolute positioned
(#208247)](#208247)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Hannah
Mudge","email":"Heenawter@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-01-24T21:42:54Z","message":"[`kbn-grid-layout`]
Make drag preview absolute positioned (#208247)\n\n##
Summary\r\n\r\nThis PR positions the drag preview via `absolute`
positioning. This is a\r\npotential fix for `EuiResizeObservers` being
fired unnecessarily.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] The PR
description includes the appropriate Release Notes section,\r\nand the
correct `release_note:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"1ff451a377fd5cde5a5d7f2e2b059d9238c43fd0","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Presentation","loe:small","impact:critical","v9.0.0","backport:prev-minor","Project:Collapsable
Panels"],"title":"[`kbn-grid-layout`] Make drag preview absolute
positioned","number":208247,"url":"https://github.com/elastic/kibana/pull/208247","mergeCommit":{"message":"[`kbn-grid-layout`]
Make drag preview absolute positioned (#208247)\n\n##
Summary\r\n\r\nThis PR positions the drag preview via `absolute`
positioning. This is a\r\npotential fix for `EuiResizeObservers` being
fired unnecessarily.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] The PR
description includes the appropriate Release Notes section,\r\nand the
correct `release_note:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"1ff451a377fd5cde5a5d7f2e2b059d9238c43fd0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208247","number":208247,"mergeCommit":{"message":"[`kbn-grid-layout`]
Make drag preview absolute positioned (#208247)\n\n##
Summary\r\n\r\nThis PR positions the drag preview via `absolute`
positioning. This is a\r\npotential fix for `EuiResizeObservers` being
fired unnecessarily.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] The PR
description includes the appropriate Release Notes section,\r\nand the
correct `release_note:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"1ff451a377fd5cde5a5d7f2e2b059d9238c43fd0"}}]}]
BACKPORT-->

Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com>
@mbondyra
Copy link
Contributor

mbondyra commented Jan 25, 2025 •
edited
Loading

@Heenawter unfortunately, this caused another bug - when resizing an element that occupies the whole space, the drag preview is not considered in space and the content after that goes up. I will create an issue about it.

@mbondyra mbondyra mentioned this pull request Jan 25, 2025
Open
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Jan 27, 2025
@Heenawter @JoseLuisGJ
[kbn-grid-layout] Make drag preview absolute positioned (elastic#20…
9af3734 
…8247)

## Summary

This PR positions the drag preview via `absolute` positioning. This is a
potential fix for `EuiResizeObservers` being fired unnecessarily.


### Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees

@Heenawter Heenawter

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) bug Fixes for quality problems that affect the customer experience impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort Project:Collapsable Panels Related to the project for adding collapsable sections to Dashboards. release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Heenawter @elasticmachine @kibanamachine @mbondyra @ThomThomson