[UA] Remove unnecessary index block settings #208222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-core (Team:Core) |
TinaHeiligers
approved these changes
Jan 24, 2025
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]
History
cc @afharo |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/13019437702 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 28, 2025
(cherry picked from commit 37eca30)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 28, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[UA] Remove unnecessary index block settings (#208222)](#208222) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alejandro Fernández Haro","email":"alejandro.haro@elastic.co"},"sourceCommit":{"committedDate":"2025-01-28T20:59:45Z","message":"[UA] Remove unnecessary index block settings (#208222)","sha":"37eca30f85553e1a7012b38112195e886112af32","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:prev-minor"],"title":"[UA] Remove unnecessary index block settings","number":208222,"url":"https://github.com/elastic/kibana/pull/208222","mergeCommit":{"message":"[UA] Remove unnecessary index block settings (#208222)","sha":"37eca30f85553e1a7012b38112195e886112af32"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208222","number":208222,"mergeCommit":{"message":"[UA] Remove unnecessary index block settings (#208222)","sha":"37eca30f85553e1a7012b38112195e886112af32"}}]}] BACKPORT--> Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #207114
The
_create_fromAPI now removes theindex.blocksettings by default. We don't need to unset them anymore.Checklist