-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Index Management] Display index mode of data streams depending on logsdb.enabled
cluster setting
#207131
[Index Management] Display index mode of data streams depending on logsdb.enabled
cluster setting
#207131
Conversation
…gsdb.enabled cluster setting
6324fd6
to
bfafc18
Compare
Pinging @elastic/kibana-management (Team:Kibana Management) |
8d6df30
to
86b4449
Compare
…com/ElenaStoeva/kibana into data-streams-logsdb-cluster-setting
b6b361c
to
089a185
Compare
089a185
to
452db2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and all works well, code changes lgtm. Thanks for adding all those tests too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x-pack/test_serverless/api_integration/services/index_management/svl_templates.helpers.ts LGTM
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]
History
cc @ElenaStoeva |
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12958252343 |
…ogsdb.enabled` cluster setting (elastic#207131) Closes elastic#206126 ## Summary This PR displays a LogsDB index mode for `logs-*-*` data streams and templates with the `logs-*-*` index pattern if the `cluster.logsdb.enabled` setting is set to true and as "Standard" if it's set to false. If the setting is not set, it is false by default in stateful (and so "Standard" index mode) and true by default in serverless (and so "LogsDB" index mode). **How to test:** In Stateful: 1. Create an index template with a `logs-*-*` index pattern 2. Create a `logs-*-*` data stream: `PUT _data_stream/logs-test-1` 3. Go to Index Management -> Index templates and click on the created index templates. Verify that the index mode is correct (**NOTE:** In stateful, the `cluster.logsdb.enabled` setting is `false` by default, while in serverless it's `true` by default. Therefore, the index mode should be `Standard` in stateful and `LogsDB` in serverless. 4. Go to Index Management -> Data Streams and find the created data stream. Verify that the index mode is correct (**NOTE:** In stateful, the `cluster.logsdb.enabled` setting is `false` by default, while in serverless it's `true` by default. Therefore, the index mode should be `Standard` in stateful and `LogsDB` in serverless. 5. In Console, set the `cluster.logsdb.enabled` setting: ``` PUT /_cluster/settings { "persistent" : { "cluster.logsdb.enabled" : true } } ``` 6. Go to the data stream/templates list and verify that the index mode of the test data stream/template that we created is displayed as LogsDB 7. Change the cluster setting to `false` and verify that the index mode is now displayed as Standard. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit b08eaa7)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
… on `logsdb.enabled` cluster setting (#207131) (#208281) # Backport This will backport the following commits from `main` to `8.x`: - [[Index Management] Display index mode of data streams depending on `logsdb.enabled` cluster setting (#207131)](#207131) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Elena Stoeva","email":"59341489+ElenaStoeva@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-01-24T21:55:16Z","message":"[Index Management] Display index mode of data streams depending on `logsdb.enabled` cluster setting (#207131)\n\nCloses https://github.com/elastic/kibana/issues/206126\r\n\r\n## Summary\r\n\r\nThis PR displays a LogsDB index mode for `logs-*-*` data streams and\r\ntemplates with the `logs-*-*` index pattern if the\r\n`cluster.logsdb.enabled` setting is set to true and as \"Standard\" if\r\nit's set to false. If the setting is not set, it is false by default in\r\nstateful (and so \"Standard\" index mode) and true by default in\r\nserverless (and so \"LogsDB\" index mode).\r\n\r\n**How to test:**\r\nIn Stateful:\r\n1. Create an index template with a `logs-*-*` index pattern\r\n2. Create a `logs-*-*` data stream: `PUT _data_stream/logs-test-1`\r\n3. Go to Index Management -> Index templates and click on the created\r\nindex templates. Verify that the index mode is correct (**NOTE:** In\r\nstateful, the `cluster.logsdb.enabled` setting is `false` by default,\r\nwhile in serverless it's `true` by default. Therefore, the index mode\r\nshould be `Standard` in stateful and `LogsDB` in serverless.\r\n4. Go to Index Management -> Data Streams and find the created data\r\nstream. Verify that the index mode is correct (**NOTE:** In stateful,\r\nthe `cluster.logsdb.enabled` setting is `false` by default, while in\r\nserverless it's `true` by default. Therefore, the index mode should be\r\n`Standard` in stateful and `LogsDB` in serverless.\r\n5. In Console, set the `cluster.logsdb.enabled` setting: \r\n```\r\nPUT /_cluster/settings\r\n{\r\n \"persistent\" : {\r\n \"cluster.logsdb.enabled\" : true\r\n }\r\n}\r\n```\r\n6. Go to the data stream/templates list and verify that the index mode\r\nof the test data stream/template that we created is displayed as LogsDB\r\n7. Change the cluster setting to `false` and verify that the index mode\r\nis now displayed as Standard.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"b08eaa7d5a170436d75ae909972bdd6770dea3b3","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index Management","Team:Kibana Management","release_note:skip","v9.0.0","backport:prev-minor","v8.18.0"],"title":"[Index Management] Display index mode of data streams depending on `logsdb.enabled` cluster setting","number":207131,"url":"https://github.com/elastic/kibana/pull/207131","mergeCommit":{"message":"[Index Management] Display index mode of data streams depending on `logsdb.enabled` cluster setting (#207131)\n\nCloses https://github.com/elastic/kibana/issues/206126\r\n\r\n## Summary\r\n\r\nThis PR displays a LogsDB index mode for `logs-*-*` data streams and\r\ntemplates with the `logs-*-*` index pattern if the\r\n`cluster.logsdb.enabled` setting is set to true and as \"Standard\" if\r\nit's set to false. If the setting is not set, it is false by default in\r\nstateful (and so \"Standard\" index mode) and true by default in\r\nserverless (and so \"LogsDB\" index mode).\r\n\r\n**How to test:**\r\nIn Stateful:\r\n1. Create an index template with a `logs-*-*` index pattern\r\n2. Create a `logs-*-*` data stream: `PUT _data_stream/logs-test-1`\r\n3. Go to Index Management -> Index templates and click on the created\r\nindex templates. Verify that the index mode is correct (**NOTE:** In\r\nstateful, the `cluster.logsdb.enabled` setting is `false` by default,\r\nwhile in serverless it's `true` by default. Therefore, the index mode\r\nshould be `Standard` in stateful and `LogsDB` in serverless.\r\n4. Go to Index Management -> Data Streams and find the created data\r\nstream. Verify that the index mode is correct (**NOTE:** In stateful,\r\nthe `cluster.logsdb.enabled` setting is `false` by default, while in\r\nserverless it's `true` by default. Therefore, the index mode should be\r\n`Standard` in stateful and `LogsDB` in serverless.\r\n5. In Console, set the `cluster.logsdb.enabled` setting: \r\n```\r\nPUT /_cluster/settings\r\n{\r\n \"persistent\" : {\r\n \"cluster.logsdb.enabled\" : true\r\n }\r\n}\r\n```\r\n6. Go to the data stream/templates list and verify that the index mode\r\nof the test data stream/template that we created is displayed as LogsDB\r\n7. Change the cluster setting to `false` and verify that the index mode\r\nis now displayed as Standard.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"b08eaa7d5a170436d75ae909972bdd6770dea3b3"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207131","number":207131,"mergeCommit":{"message":"[Index Management] Display index mode of data streams depending on `logsdb.enabled` cluster setting (#207131)\n\nCloses https://github.com/elastic/kibana/issues/206126\r\n\r\n## Summary\r\n\r\nThis PR displays a LogsDB index mode for `logs-*-*` data streams and\r\ntemplates with the `logs-*-*` index pattern if the\r\n`cluster.logsdb.enabled` setting is set to true and as \"Standard\" if\r\nit's set to false. If the setting is not set, it is false by default in\r\nstateful (and so \"Standard\" index mode) and true by default in\r\nserverless (and so \"LogsDB\" index mode).\r\n\r\n**How to test:**\r\nIn Stateful:\r\n1. Create an index template with a `logs-*-*` index pattern\r\n2. Create a `logs-*-*` data stream: `PUT _data_stream/logs-test-1`\r\n3. Go to Index Management -> Index templates and click on the created\r\nindex templates. Verify that the index mode is correct (**NOTE:** In\r\nstateful, the `cluster.logsdb.enabled` setting is `false` by default,\r\nwhile in serverless it's `true` by default. Therefore, the index mode\r\nshould be `Standard` in stateful and `LogsDB` in serverless.\r\n4. Go to Index Management -> Data Streams and find the created data\r\nstream. Verify that the index mode is correct (**NOTE:** In stateful,\r\nthe `cluster.logsdb.enabled` setting is `false` by default, while in\r\nserverless it's `true` by default. Therefore, the index mode should be\r\n`Standard` in stateful and `LogsDB` in serverless.\r\n5. In Console, set the `cluster.logsdb.enabled` setting: \r\n```\r\nPUT /_cluster/settings\r\n{\r\n \"persistent\" : {\r\n \"cluster.logsdb.enabled\" : true\r\n }\r\n}\r\n```\r\n6. Go to the data stream/templates list and verify that the index mode\r\nof the test data stream/template that we created is displayed as LogsDB\r\n7. Change the cluster setting to `false` and verify that the index mode\r\nis now displayed as Standard.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"b08eaa7d5a170436d75ae909972bdd6770dea3b3"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Elena Stoeva <59341489+ElenaStoeva@users.noreply.github.com>
Closes #206126
Summary
This PR displays a LogsDB index mode for
logs-*-*
data streams and templates with thelogs-*-*
index pattern if thecluster.logsdb.enabled
setting is set to true and as "Standard" if it's set to false. If the setting is not set, it is false by default in stateful (and so "Standard" index mode) and true by default in serverless (and so "LogsDB" index mode).How to test:
In Stateful:
logs-*-*
index patternlogs-*-*
data stream:PUT _data_stream/logs-test-1
cluster.logsdb.enabled
setting isfalse
by default, while in serverless it'strue
by default. Therefore, the index mode should beStandard
in stateful andLogsDB
in serverless.cluster.logsdb.enabled
setting isfalse
by default, while in serverless it'strue
by default. Therefore, the index mode should beStandard
in stateful andLogsDB
in serverless.cluster.logsdb.enabled
setting:false
and verify that the index mode is now displayed as Standard.