Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Display versions in Rule Upgrade flyout #206636

Merged
merged 2 commits into from
Jan 16, 2025
Merged

[Security Solution] Display versions in Rule Upgrade flyout #206636

merged 2 commits into from
Jan 16, 2025
+25 −6

Conversation

nikitaindik
Copy link
Contributor

@nikitaindik nikitaindik commented Jan 14, 2025 •
edited by kibanamachine
Loading

Resolves: #188065

Summary

This PR adds current and target version info in the header of the Rule Upgrade flyout.

Screenshots

Before
Scherm­afbeelding 2025-01-14 om 17 44 37

After
Scherm­afbeelding 2025-01-14 om 17 43 58

Work started on: 14-Jan-2025

@nikitaindik nikitaindik added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area backport:version Backport to applied version labels v8.18.0 labels Jan 14, 2025
@nikitaindik nikitaindik self-assigned this Jan 14, 2025
@nikitaindik nikitaindik requested a review from a team as a code owner January 14, 2025 16:47
@nikitaindik nikitaindik requested a review from xcrzx January 14, 2025 16:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@nikitaindik nikitaindik requested review from maximpn and removed request for xcrzx January 14, 2025 16:47
@nikitaindik nikitaindik mentioned this pull request Jan 14, 2025
Closed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 21.1MB 21.1MB +318.0B

History

cc @nikitaindik

maximpn
maximpn approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@maximpn maximpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikitaindik nikitaindik merged commit 138d034 into elastic:main Jan 16, 2025
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12805950134

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 16, 2025
@nikitaindik
[Security Solution] Display versions in Rule Upgrade flyout (elastic#…
4b40cb7 
…206636)

**Resolves: elastic#188065

## Summary
This PR adds current and target version info in the header of the Rule
Upgrade flyout.

## Screenshots
**Before**
<img width="975" alt="Scherm­afbeelding 2025-01-14 om 17 44 37"
src="https://github.com/user-attachments/assets/d831ffdb-a96f-40cc-8f46-1ae8d9d6e2cf"
/>

**After**
<img width="975" alt="Scherm­afbeelding 2025-01-14 om 17 43 58"
src="https://github.com/user-attachments/assets/91ebff9a-a10a-4d65-b696-42b6756bbacf"
/>

Work started on: 14-Jan-2025

(cherry picked from commit 138d034)
@kibanamachine kibanamachine mentioned this pull request Jan 16, 2025
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 16, 2025
@kibanamachine @nikitaindik
[8.x] [Security Solution] Display versions in Rule Upgrade flyout (#2…
2dd149d 
…06636) (#206912)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution] Display versions in Rule Upgrade flyout
(#206636)](#206636)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nikita
Indik","email":"nikita.indik@elastic.co"},"sourceCommit":{"committedDate":"2025-01-16T09:31:18Z","message":"[Security
Solution] Display versions in Rule Upgrade flyout
(#206636)\n\n**Resolves:
https://github.com/elastic/kibana/issues/188065**\n\n## Summary\nThis PR
adds current and target version info in the header of the Rule\nUpgrade
flyout.\n\n## Screenshots\n**Before**\n<img width=\"975\"
alt=\"Scherm­afbeelding 2025-01-14 om 17 44
37\"\nsrc=\"https://github.com/user-attachments/assets/d831ffdb-a96f-40cc-8f46-1ae8d9d6e2cf\"\n/>\n\n**After**\n<img
width=\"975\" alt=\"Scherm­afbeelding 2025-01-14 om 17 43
58\"\nsrc=\"https://github.com/user-attachments/assets/91ebff9a-a10a-4d65-b696-42b6756bbacf\"\n/>\n\nWork
started on:
14-Jan-2025","sha":"138d034d9fa656ed18bd31d344033d5831818092","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection Rule
Management","Feature:Prebuilt Detection
Rules","backport:version","v8.18.0"],"title":"[Security Solution]
Display versions in Rule Upgrade
flyout","number":206636,"url":"https://github.com/elastic/kibana/pull/206636","mergeCommit":{"message":"[Security
Solution] Display versions in Rule Upgrade flyout
(#206636)\n\n**Resolves:
https://github.com/elastic/kibana/issues/188065**\n\n## Summary\nThis PR
adds current and target version info in the header of the Rule\nUpgrade
flyout.\n\n## Screenshots\n**Before**\n<img width=\"975\"
alt=\"Scherm­afbeelding 2025-01-14 om 17 44
37\"\nsrc=\"https://github.com/user-attachments/assets/d831ffdb-a96f-40cc-8f46-1ae8d9d6e2cf\"\n/>\n\n**After**\n<img
width=\"975\" alt=\"Scherm­afbeelding 2025-01-14 om 17 43
58\"\nsrc=\"https://github.com/user-attachments/assets/91ebff9a-a10a-4d65-b696-42b6756bbacf\"\n/>\n\nWork
started on:
14-Jan-2025","sha":"138d034d9fa656ed18bd31d344033d5831818092"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206636","number":206636,"mergeCommit":{"message":"[Security
Solution] Display versions in Rule Upgrade flyout
(#206636)\n\n**Resolves:
https://github.com/elastic/kibana/issues/188065**\n\n## Summary\nThis PR
adds current and target version info in the header of the Rule\nUpgrade
flyout.\n\n## Screenshots\n**Before**\n<img width=\"975\"
alt=\"Scherm­afbeelding 2025-01-14 om 17 44
37\"\nsrc=\"https://github.com/user-attachments/assets/d831ffdb-a96f-40cc-8f46-1ae8d9d6e2cf\"\n/>\n\n**After**\n<img
width=\"975\" alt=\"Scherm­afbeelding 2025-01-14 om 17 43
58\"\nsrc=\"https://github.com/user-attachments/assets/91ebff9a-a10a-4d65-b696-42b6756bbacf\"\n/>\n\nWork
started on:
14-Jan-2025","sha":"138d034d9fa656ed18bd31d344033d5831818092"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nikita Indik <nikita.indik@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximpn maximpn maximpn approved these changes

Assignees

@nikitaindik nikitaindik

Labels
backport:version Backport to applied version labels Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security Solution] Handle specific fields in the upgrade workflow's UI
4 participants
@nikitaindik @elasticmachine @kibanamachine @maximpn