-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Beats module and input info to Telemetry #20648
Add Beats module and input info to Telemetry #20648
Conversation
💚 Build Succeeded |
I assume the schema changes you mention above are the ones needed in Elasticsearch? Or are there also schema changes needed in KB? I will take for of the changes in ES. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good to me. Do you plan to add the host
info like platform
in a follow up PR? See here for an example: elastic/beats#7537
Unfortunately the queue type PR is still open.
clusterModuleSets[clusterUuid] = new Set(); | ||
} | ||
|
||
// beats_stats |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: I see you have this section of code here for processing beats_stats
results and further down a section of code for processing beats_state
results. I think it might be a bit more readable if you extracted each section into its own respective function, something like processBeatsStatsResults
and processBeatsStateResults
, and then call those from here.
Hi, unfortunately I didn't realize those parts were also part of the scope of this work, and the queue name which is still an open PR would put me in a hanging state. If we need that in 6.4 as well, I will try to find someone who can take it on. |
💔 Build Failed |
@tsullivan With input and module we definitively have the 2 most important ones. host / platform would be great to have. Let's skip queue for now. |
unrelated selenium failure jenkins test this |
💚 Build Succeeded |
* fix metrics field name (stats) * add state info * add module name count * use a set for the unique hosts instead of a map * fix getting beats_state info * fix unit test * processBeatsStatsResults and processBeatsStateResults
6.x/6.4.0: #20856 |
Carry on from #18833
(No release notes needd)
This adds the following info to Beats telemetry data payload:
To test:
This may be blocked by elastic/beats#7562.