Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Eui visual refresh - make palettes theme aware #205873

Merged
merged 17 commits into from
Feb 10, 2025
Merged

[Security Solution] Eui visual refresh - make palettes theme aware #205873

merged 17 commits into from
Feb 10, 2025

Conversation

lgestc
Copy link
Contributor

@lgestc lgestc commented Jan 8, 2025 •
edited
Loading

Summary

This PR resolves #201882 by making sure that EUI palette functions are called during component re-renders in Security Solution.

Testing

Please verify if visualizations are displayed properly.

Running Kibana with the Borealis theme
In order to run Kibana with Borealis, you'll need to do the following:

Set the following in kibana.dev.yml: uiSettings.experimental.themeSwitcherEnabled: true

Run Kibana with the following environment variable set:
KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn start

This will expose a toggle under Stack Management > Advanced Settings > Theme version, which you can use to toggle between Amsterdam and Borealis.

@lgestc lgestc changed the title --wip-- [skip ci] [Security Solution] Eui visual refresh - make palettes theme aware Jan 8, 2025
@elastic elastic deleted a comment from elasticmachine Jan 8, 2025
@lgestc lgestc marked this pull request as ready for review January 8, 2025 19:41
@lgestc lgestc requested a review from a team as a code owner January 8, 2025 19:41
@lgestc lgestc added backport:skip This commit does not require backporting Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting:Explore labels Jan 8, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

@lgestc lgestc requested a review from machadoum January 8, 2025 19:42
@lgestc lgestc added the release_note:skip Skip the PR/issue when compiling release notes label Jan 8, 2025
angorayc
angorayc reviewed Jan 10, 2025
View reviewed changes
Copy link
Contributor

@angorayc angorayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Lucas, thanks so much for updating the configs for map and visualizations:
I think we can keep the changes for map, as for visualizations should have been updated in the PRs below:
#204631 (comment)
#206254

@lgestc lgestc force-pushed the ensure_pallete_reload_on_rerender branch from 3fce630 to 9825390 Compare January 13, 2025 14:06
@lgestc
Copy link
Contributor Author

lgestc commented Jan 13, 2025 •
edited
Loading

Hey Lucas, thanks so much for updating the configs for map and visualizations: I think we can keep the changes for map, as for visualizations should have been updated in the PRs below: #204631 (comment) #206254

Done, this PR is just about the map config now:) @angorayc

@lgestc lgestc requested a review from angorayc January 14, 2025 17:14
@elastic elastic deleted a comment from elasticmachine Jan 27, 2025
mgadewoll
mgadewoll approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Code changes LGTM from EUI side.

@lgestc lgestc enabled auto-merge (squash) February 10, 2025 08:00
@lgestc lgestc merged commit bcb3d70 into elastic:main Feb 10, 2025
9 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #8 / Mappings editor: scaled float datatype should require a scaling factor to be provided

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 21.4MB 21.4MB +194.0B

History

Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Feb 10, 2025
@lgestc @Samiul-TheSoccerFan
[Security Solution] Eui visual refresh - make palettes theme aware (e…
4daa233 
…lastic#205873)

## Summary

This PR resolves elastic#201882 by
making sure that EUI palette functions are called during component
re-renders in Security Solution.

### Testing

Please verify if visualizations are displayed properly.

Running Kibana with the Borealis theme
In order to run Kibana with Borealis, you'll need to do the following:

Set the following in kibana.dev.yml:
`uiSettings.experimental.themeSwitcherEnabled: true`

Run Kibana with the following environment variable set:
`KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn
start`

This will expose a toggle under Stack Management > Advanced Settings >
Theme version, which you can use to toggle between Amsterdam and
Borealis.
tkajtoch pushed a commit to tkajtoch/kibana that referenced this pull request Feb 14, 2025
@lgestc
[Security Solution] Eui visual refresh - make palettes theme aware (e…
eae307d 
…lastic#205873)

## Summary

This PR resolves elastic#201882 by
making sure that EUI palette functions are called during component
re-renders in Security Solution.

### Testing

Please verify if visualizations are displayed properly.

Running Kibana with the Borealis theme
In order to run Kibana with Borealis, you'll need to do the following:

Set the following in kibana.dev.yml:
`uiSettings.experimental.themeSwitcherEnabled: true`

Run Kibana with the following environment variable set:
`KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn
start`

This will expose a toggle under Stack Management > Advanced Settings >
Theme version, which you can use to toggle between Amsterdam and
Borealis.

(cherry picked from commit bcb3d70)

# Conflicts:
#	x-pack/solutions/security/plugins/security_solution/public/explore/network/components/embeddables/__mocks__/mock.ts
@tkajtoch tkajtoch mentioned this pull request Feb 14, 2025
Merged
@tkajtoch
Copy link
Member

💚 All backports created successfully

Status Branch Result
✅ 9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

tkajtoch added a commit that referenced this pull request Feb 19, 2025
@tkajtoch @lgestc @elasticmachine
[9.0] [Security Solution] Eui visual refresh - make palettes theme aw…
72cd91a 
…are (#205873) (#211222)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[Security Solution] Eui visual refresh - make palettes theme aware
(#205873)](#205873)

<!--- Backport version: 9.6.4 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Luke
Gmys","email":"11671118+lgestc@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-10T10:05:23Z","message":"[Security
Solution] Eui visual refresh - make palettes theme aware (#205873)\n\n##
Summary\r\n\r\nThis PR resolves
#201882 by\r\nmaking sure that
EUI palette functions are called during component\r\nre-renders in
Security Solution.\r\n\r\n### Testing\r\n\r\nPlease verify if
visualizations are displayed properly.\r\n\r\nRunning Kibana with the
Borealis theme\r\nIn order to run Kibana with Borealis, you'll need to
do the following:\r\n\r\nSet the following in
kibana.dev.yml:\r\n`uiSettings.experimental.themeSwitcherEnabled:
true`\r\n\r\nRun Kibana with the following environment variable
set:\r\n`KBN_OPTIMIZER_THEMES=\"borealislight,borealisdark,v8light,v8dark\"
yarn\r\nstart`\r\n\r\nThis will expose a toggle under Stack Management >
Advanced Settings >\r\nTheme version, which you can use to toggle
between Amsterdam
and\r\nBorealis.","sha":"bcb3d709b99ebe05a2a193fc975c680700bcfe73","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","Team:Threat
Hunting:Investigations","Team:Threat Hunting:Explore","EUI Visual
Refresh","v9.1.0"],"title":"[Security Solution] Eui visual refresh -
make palettes theme
aware","number":205873,"url":"https://github.com/elastic/kibana/pull/205873","mergeCommit":{"message":"[Security
Solution] Eui visual refresh - make palettes theme aware (#205873)\n\n##
Summary\r\n\r\nThis PR resolves
#201882 by\r\nmaking sure that
EUI palette functions are called during component\r\nre-renders in
Security Solution.\r\n\r\n### Testing\r\n\r\nPlease verify if
visualizations are displayed properly.\r\n\r\nRunning Kibana with the
Borealis theme\r\nIn order to run Kibana with Borealis, you'll need to
do the following:\r\n\r\nSet the following in
kibana.dev.yml:\r\n`uiSettings.experimental.themeSwitcherEnabled:
true`\r\n\r\nRun Kibana with the following environment variable
set:\r\n`KBN_OPTIMIZER_THEMES=\"borealislight,borealisdark,v8light,v8dark\"
yarn\r\nstart`\r\n\r\nThis will expose a toggle under Stack Management >
Advanced Settings >\r\nTheme version, which you can use to toggle
between Amsterdam
and\r\nBorealis.","sha":"bcb3d709b99ebe05a2a193fc975c680700bcfe73"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205873","number":205873,"mergeCommit":{"message":"[Security
Solution] Eui visual refresh - make palettes theme aware (#205873)\n\n##
Summary\r\n\r\nThis PR resolves
#201882 by\r\nmaking sure that
EUI palette functions are called during component\r\nre-renders in
Security Solution.\r\n\r\n### Testing\r\n\r\nPlease verify if
visualizations are displayed properly.\r\n\r\nRunning Kibana with the
Borealis theme\r\nIn order to run Kibana with Borealis, you'll need to
do the following:\r\n\r\nSet the following in
kibana.dev.yml:\r\n`uiSettings.experimental.themeSwitcherEnabled:
true`\r\n\r\nRun Kibana with the following environment variable
set:\r\n`KBN_OPTIMIZER_THEMES=\"borealislight,borealisdark,v8light,v8dark\"
yarn\r\nstart`\r\n\r\nThis will expose a toggle under Stack Management >
Advanced Settings >\r\nTheme version, which you can use to toggle
between Amsterdam
and\r\nBorealis.","sha":"bcb3d709b99ebe05a2a193fc975c680700bcfe73"}}]}]
BACKPORT-->

Co-authored-by: Luke Gmys <11671118+lgestc@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angorayc angorayc angorayc approved these changes

@mgadewoll mgadewoll mgadewoll approved these changes

@machadoum machadoum Awaiting requested review from machadoum

@codearos codearos Awaiting requested review from codearos

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting EUI Visual Refresh release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore Team:Threat Hunting:Investigations Security Solution Investigations Team v9.0.0 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security Solution][EUI visual refresh] make sure color palettes are theme aware
7 participants
@lgestc @elasticmachine @tkajtoch @angorayc @mgadewoll @codearos @kibanamachine