[ES|QL] capitalize FROM in recommended queries
#205122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-esql (Team:ESQL) |
💚 Build Succeeded
Metrics [docs]
|
mbondyra
approved these changes
Dec 30, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12579628127 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 2, 2025
## Summary `FROM` wasn't capitalized when selected from the menu: https://github.com/user-attachments/assets/939c24b6-5ae5-417b-9dfa-fb4d411b8abc Now it is. Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co> (cherry picked from commit e5cf28b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 2, 2025
…5122) (#205352) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] capitalize `FROM` in recommended queries (#205122)](#205122) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Drew Tate","email":"drew.tate@elastic.co"},"sourceCommit":{"committedDate":"2025-01-02T08:30:42Z","message":"[ES|QL] capitalize `FROM` in recommended queries (#205122)\n\n## Summary\r\n\r\n`FROM` wasn't capitalized when selected from the menu:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/939c24b6-5ae5-417b-9dfa-fb4d411b8abc\r\n\r\n\r\n\r\nNow it is.\r\n\r\nCo-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>","sha":"e5cf28bc27b6ca80c92c44a4fc805adce857b518","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Feature:ES|QL","Team:ESQL","backport:version","v8.18.0"],"title":"[ES|QL] capitalize `FROM` in recommended queries","number":205122,"url":"https://github.com/elastic/kibana/pull/205122","mergeCommit":{"message":"[ES|QL] capitalize `FROM` in recommended queries (#205122)\n\n## Summary\r\n\r\n`FROM` wasn't capitalized when selected from the menu:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/939c24b6-5ae5-417b-9dfa-fb4d411b8abc\r\n\r\n\r\n\r\nNow it is.\r\n\r\nCo-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>","sha":"e5cf28bc27b6ca80c92c44a4fc805adce857b518"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205122","number":205122,"mergeCommit":{"message":"[ES|QL] capitalize `FROM` in recommended queries (#205122)\n\n## Summary\r\n\r\n`FROM` wasn't capitalized when selected from the menu:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/939c24b6-5ae5-417b-9dfa-fb4d411b8abc\r\n\r\n\r\n\r\nNow it is.\r\n\r\nCo-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>","sha":"e5cf28bc27b6ca80c92c44a4fc805adce857b518"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Drew Tate <drew.tate@elastic.co>
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Jan 2, 2025
## Summary `FROM` wasn't capitalized when selected from the menu: https://github.com/user-attachments/assets/939c24b6-5ae5-417b-9dfa-fb4d411b8abc Now it is. Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Jan 2, 2025
## Summary `FROM` wasn't capitalized when selected from the menu: https://github.com/user-attachments/assets/939c24b6-5ae5-417b-9dfa-fb4d411b8abc Now it is. Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
## Summary `FROM` wasn't capitalized when selected from the menu: https://github.com/user-attachments/assets/939c24b6-5ae5-417b-9dfa-fb4d411b8abc Now it is. Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
FROMwasn't capitalized when selected from the menu:Screen.Recording.2024-12-23.at.2.42.55.PM.mov
Now it is.