Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][threat hunting explore] EUI refresh: Rename color variables #204908

Merged
merged 20 commits into from
Jan 9, 2025
Merged

[Security Solution][threat hunting explore] EUI refresh: Rename color variables #204908

merged 20 commits into from
Jan 9, 2025
+58 −50

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Dec 19, 2024 •
edited
Loading

Summary

#202499

Running Kibana with the Borealis theme

In order to run Kibana with Borealis, you'll need to do the following:

Set the following in kibana.dev.yml: uiSettings.experimental.themeSwitcherEnabled: true

Run Kibana with the following environment variable set:
KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn start

This will expose a toggle under Stack Management > Advanced Settings > Theme version, which you can use to toggle between Amsterdam and Borealis.

Image

@angorayc angorayc mentioned this pull request Dec 19, 2024
Closed
mgadewoll
mgadewoll reviewed Dec 19, 2024
View reviewed changes
Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ Adding an early review due to upcoming PTO

@angorayc angorayc marked this pull request as ready for review December 19, 2024 17:22
@angorayc angorayc requested review from a team as code owners December 19, 2024 17:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

@angorayc angorayc mentioned this pull request Jan 7, 2025
Open
CAWilson94
CAWilson94 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@CAWilson94 CAWilson94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work! 🚀

@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 8, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

mgadewoll
mgadewoll approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks for the additional updates! Changes LGTM me from EUI side.
I left one small non-blocking suggestion, if you still feel like updating 😅

agusruidiazgd
agusruidiazgd approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@agusruidiazgd agusruidiazgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Angela!!

@codearos
Copy link

codearos commented Jan 9, 2025

LGTM Thank you!

From our review sync: We need an option for illustrated icons for dark theme. This work will be in separate issue.

@angorayc angorayc merged commit 0c0dd63 into elastic:main Jan 9, 2025
8 checks passed
Zacqary pushed a commit to Zacqary/kibana that referenced this pull request Jan 9, 2025
@angorayc @kibanamachine @Zacqary
[Security Solution][threat hunting explore] EUI refresh: Rename color…
2146474 
… variables (elastic#204908)

## Summary

elastic#202499

### Running Kibana with the Borealis theme
In order to run Kibana with Borealis, you'll need to do the following:

Set the following in kibana.dev.yml:
uiSettings.experimental.themeSwitcherEnabled: true

Run Kibana with the following environment variable set:
KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn
start

This will expose a toggle under Stack Management > Advanced Settings >
Theme version, which you can use to toggle between Amsterdam and
Borealis.


![Image](https://github.com/user-attachments/assets/78d64946-43fc-4400-bbb1-229d900b7f05)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
@angorayc @kibanamachine @CAWilson94
[Security Solution][threat hunting explore] EUI refresh: Rename color…
b018525 
… variables (elastic#204908)

## Summary

elastic#202499

### Running Kibana with the Borealis theme
In order to run Kibana with Borealis, you'll need to do the following:

Set the following in kibana.dev.yml:
uiSettings.experimental.themeSwitcherEnabled: true

Run Kibana with the following environment variable set:
KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn
start

This will expose a toggle under Stack Management > Advanced Settings >
Theme version, which you can use to toggle between Amsterdam and
Borealis.


![Image](https://github.com/user-attachments/assets/78d64946-43fc-4400-bbb1-229d900b7f05)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
@angorayc @kibanamachine @viduni94
[Security Solution][threat hunting explore] EUI refresh: Rename color…
c30c15d 
… variables (elastic#204908)

## Summary

elastic#202499

### Running Kibana with the Borealis theme
In order to run Kibana with Borealis, you'll need to do the following:

Set the following in kibana.dev.yml:
uiSettings.experimental.themeSwitcherEnabled: true

Run Kibana with the following environment variable set:
KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn
start

This will expose a toggle under Stack Management > Advanced Settings >
Theme version, which you can use to toggle between Amsterdam and
Borealis.


![Image](https://github.com/user-attachments/assets/78d64946-43fc-4400-bbb1-229d900b7f05)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
angorayc added a commit to angorayc/kibana that referenced this pull request Feb 12, 2025
@angorayc
[Security Solution][threat hunting explore] EUI refresh: Rename color…
728fd61 
… variables (elastic#204908)

elastic#202499

In order to run Kibana with Borealis, you'll need to do the following:

Set the following in kibana.dev.yml:
uiSettings.experimental.themeSwitcherEnabled: true

Run Kibana with the following environment variable set:
KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn
start

This will expose a toggle under Stack Management > Advanced Settings >
Theme version, which you can use to toggle between Amsterdam and
Borealis.

![Image](https://github.com/user-attachments/assets/78d64946-43fc-4400-bbb1-229d900b7f05)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0c0dd63)
@angorayc angorayc mentioned this pull request Feb 12, 2025
Merged
angorayc added a commit to angorayc/kibana that referenced this pull request Feb 12, 2025
@angorayc
[Security Solution][threat hunting explore] EUI refresh: Rename color…
8751b4c 
… variables (elastic#204908)

elastic#202499

In order to run Kibana with Borealis, you'll need to do the following:

Set the following in kibana.dev.yml:
uiSettings.experimental.themeSwitcherEnabled: true

Run Kibana with the following environment variable set:
KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn
start

This will expose a toggle under Stack Management > Advanced Settings >
Theme version, which you can use to toggle between Amsterdam and
Borealis.

![Image](https://github.com/user-attachments/assets/78d64946-43fc-4400-bbb1-229d900b7f05)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0c0dd63)
@angorayc angorayc mentioned this pull request Feb 12, 2025
Merged
@angorayc angorayc added backport v8.18.0 and removed backport:skip This commit does not require backporting labels Feb 12, 2025
angorayc added a commit that referenced this pull request Feb 13, 2025
@angorayc
[8.x][Security Solution][threat hunting explore] EUI refresh: Rename …
043545b 
…color variables (#210850)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution][threat hunting explore] EUI refresh: Rename color
variables (#204908)](#204908)
angorayc added a commit that referenced this pull request Feb 13, 2025
@angorayc
[8.18][Security Solution][threat hunting explore] EUI refresh: Rename…
81eb63a 
… color variables (#210849)

# Backport

This will backport the following commits from `main` to `8.18`:
- [[Security Solution][threat hunting explore] EUI refresh: Rename color
variables (#204908)](#204908)
@angorayc angorayc removed the backport label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAWilson94 CAWilson94 CAWilson94 approved these changes

@mgadewoll mgadewoll mgadewoll approved these changes

@agusruidiazgd agusruidiazgd agusruidiazgd approved these changes

@joeypoon joeypoon Awaiting requested review from joeypoon joeypoon was automatically assigned from elastic/security-defend-workflows

@parkiino parkiino Awaiting requested review from parkiino parkiino was automatically assigned from elastic/security-defend-workflows

Assignees
No one assigned
Labels
EUI Visual Refresh release_note:fix Team:Threat Hunting:Explore v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@angorayc @elasticmachine @codearos @CAWilson94 @mgadewoll @agusruidiazgd @kibanamachine