Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default elser deployment for product documentation #204760

Merged

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Dec 18, 2024

Summary

Fix #204559

Use the default ELSER deployment (.elser-2-elasticsearch) for the product documentation semantic_text fields instead of maintaining our own custom deployment.

@pgayvallet pgayvallet added release_note:skip Skip the PR/issue when compiling release notes Team:AI Infra AppEx AI Infrastructure Team labels Dec 18, 2024
@pgayvallet
Copy link
Contributor Author

/ci

1 similar comment
@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet pgayvallet force-pushed the kbn-204559-product-doc-default-elser branch from 5df3036 to 6575a30 Compare December 19, 2024 07:52
@pgayvallet
Copy link
Contributor Author

/ci

1 similar comment
@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet pgayvallet marked this pull request as ready for review December 19, 2024 13:11
@pgayvallet pgayvallet requested a review from a team as a code owner December 19, 2024 13:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-ai-infra (Team:AI Infra)

@pgayvallet pgayvallet added backport:version Backport to applied version labels v8.18.0 labels Dec 19, 2024
@pgayvallet pgayvallet force-pushed the kbn-204559-product-doc-default-elser branch from 5259978 to 0c2403d Compare December 23, 2024 08:21
@pgayvallet pgayvallet force-pushed the kbn-204559-product-doc-default-elser branch from aa8aa90 to c99ed8b Compare January 6, 2025 07:44
@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet
Copy link
Contributor Author

@elasticmachine merge upstream

1 similar comment
@pgayvallet
Copy link
Contributor Author

@elasticmachine merge upstream

@pgayvallet pgayvallet added the Feature:AI Product Docs Product Documentation for AI workflows label Jan 7, 2025
@pgayvallet pgayvallet requested a review from legrego January 7, 2025 12:53
@pgayvallet pgayvallet force-pushed the kbn-204559-product-doc-default-elser branch from 5241663 to f1e102b Compare January 8, 2025 13:16
@pgayvallet
Copy link
Contributor Author

/ci

1 similar comment
@pgayvallet
Copy link
Contributor Author

/ci

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
inference 26 27 +1
observabilityAIAssistantApp 418 419 +1
observabilityAiAssistantManagement 387 388 +1
searchAssistant 261 262 +1
total +4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/inference-common 53 55 +2
Unknown metric groups

API count

id before after diff
@kbn/inference-common 157 160 +3

History

@pgayvallet pgayvallet merged commit 015911d into elastic:main Jan 8, 2025
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12677495184

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 8, 2025
## Summary

Fix elastic#204559

Use the default ELSER deployment (`.elser-2-elasticsearch`) for the
product documentation semantic_text fields instead of maintaining our
own custom deployment.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 015911d)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 8, 2025
#205956)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Use default elser deployment for product documentation
(#204760)](#204760)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Pierre
Gayvallet","email":"pierre.gayvallet@elastic.co"},"sourceCommit":{"committedDate":"2025-01-08T19:17:14Z","message":"Use
default elser deployment for product documentation (#204760)\n\n##
Summary\r\n\r\nFix
https://github.com/elastic/kibana/issues/204559\r\n\r\nUse the default
ELSER deployment (`.elser-2-elasticsearch`) for the\r\nproduct
documentation semantic_text fields instead of maintaining our\r\nown
custom deployment.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"015911d2bbeb3d750cef5f4868e9226544f70835","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","Team:AI
Infra","v8.18.0","Feature:AI Product Docs"],"title":"Use default elser
deployment for product
documentation","number":204760,"url":"https://github.com/elastic/kibana/pull/204760","mergeCommit":{"message":"Use
default elser deployment for product documentation (#204760)\n\n##
Summary\r\n\r\nFix
https://github.com/elastic/kibana/issues/204559\r\n\r\nUse the default
ELSER deployment (`.elser-2-elasticsearch`) for the\r\nproduct
documentation semantic_text fields instead of maintaining our\r\nown
custom deployment.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"015911d2bbeb3d750cef5f4868e9226544f70835"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204760","number":204760,"mergeCommit":{"message":"Use
default elser deployment for product documentation (#204760)\n\n##
Summary\r\n\r\nFix
https://github.com/elastic/kibana/issues/204559\r\n\r\nUse the default
ELSER deployment (`.elser-2-elasticsearch`) for the\r\nproduct
documentation semantic_text fields instead of maintaining our\r\nown
custom deployment.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"015911d2bbeb3d750cef5f4868e9226544f70835"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Pierre Gayvallet <pierre.gayvallet@elastic.co>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
## Summary

Fix elastic#204559

Use the default ELSER deployment (`.elser-2-elasticsearch`) for the
product documentation semantic_text fields instead of maintaining our
own custom deployment.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
## Summary

Fix elastic#204559

Use the default ELSER deployment (`.elser-2-elasticsearch`) for the
product documentation semantic_text fields instead of maintaining our
own custom deployment.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels Feature:AI Product Docs Product Documentation for AI workflows release_note:skip Skip the PR/issue when compiling release notes Team:AI Infra AppEx AI Infrastructure Team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Product documentation] Use default ELSER deployment
4 participants