Fix code scanning alert no. 494: Incomplete string escaping or encoding #204528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
Tested locally, it works as expected. And it passes the helper tests. |
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
cc @fkanout |
kdelemme
approved these changes
Dec 17, 2024
| @@ -18,7 +18,7 @@ export const getLensOperationFromRuleMetric = (metric: GenericMetric): LensOpera | |||
| const { aggType, field, filter = '' } = metric; | |||
| let operation: string = aggType; | |||
| const operationArgs: string[] = []; | |||
| const escapedFilter = filter.replace(/'/g, "\\'"); | |||
| const escapedFilter = filter.replace(/\\/g, '\\\\').replace(/'/g, "\\'"); | |||
There was a problem hiding this comment.
Can we add a test for this helper that fails before this fix?
There was a problem hiding this comment.
@maryam-saeidi I have already added a test for this helper in another PR. This PR is security-related only.
There was a problem hiding this comment.
Oh, really? Thanks for sharing. How does it work if we add a test before having the actual fix? I am not familiar with how the security scanning works.
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12377521690 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 17, 2024
…ng (elastic#204528) Fixes [https://github.com/elastic/kibana/security/code-scanning/494](https://github.com/elastic/kibana/security/code-scanning/494) Fixes elastic#1311 Escape first backslash occurrences and all single quotes in the `filter` string. (cherry picked from commit cc34e97)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
stephmilovic
pushed a commit
that referenced
this pull request
Dec 17, 2024
…encoding (#204528) (#204616) # Backport This will backport the following commits from `main` to `8.x`: - [Fix code scanning alert no. 494: Incomplete string escaping or encoding (#204528)](#204528) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Faisal Kanout","email":"faisal.kanout@elastic.co"},"sourceCommit":{"committedDate":"2024-12-17T16:45:16Z","message":"Fix code scanning alert no. 494: Incomplete string escaping or encoding (#204528)\n\nFixes\r\n[https://github.com/elastic/kibana/security/code-scanning/494](https://github.com/elastic/kibana/security/code-scanning/494)\r\nFixes #1311\r\n\r\nEscape first backslash occurrences and all single quotes in the `filter`\r\nstring.","sha":"cc34e97de4d2d8a5509eec5e4f9ffcb7338ed54a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:obs-ux-management"],"title":"Fix code scanning alert no. 494: Incomplete string escaping or encoding","number":204528,"url":"https://github.com/elastic/kibana/pull/204528","mergeCommit":{"message":"Fix code scanning alert no. 494: Incomplete string escaping or encoding (#204528)\n\nFixes\r\n[https://github.com/elastic/kibana/security/code-scanning/494](https://github.com/elastic/kibana/security/code-scanning/494)\r\nFixes #1311\r\n\r\nEscape first backslash occurrences and all single quotes in the `filter`\r\nstring.","sha":"cc34e97de4d2d8a5509eec5e4f9ffcb7338ed54a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204528","number":204528,"mergeCommit":{"message":"Fix code scanning alert no. 494: Incomplete string escaping or encoding (#204528)\n\nFixes\r\n[https://github.com/elastic/kibana/security/code-scanning/494](https://github.com/elastic/kibana/security/code-scanning/494)\r\nFixes #1311\r\n\r\nEscape first backslash occurrences and all single quotes in the `filter`\r\nstring.","sha":"cc34e97de4d2d8a5509eec5e4f9ffcb7338ed54a"}}]}] BACKPORT--> Co-authored-by: Faisal Kanout <faisal.kanout@elastic.co>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Dec 19, 2024
…ng (elastic#204528) Fixes [https://github.com/elastic/kibana/security/code-scanning/494](https://github.com/elastic/kibana/security/code-scanning/494) Fixes elastic#1311 Escape first backslash occurrences and all single quotes in the `filter` string.
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Jan 2, 2025
…ng (elastic#204528) Fixes [https://github.com/elastic/kibana/security/code-scanning/494](https://github.com/elastic/kibana/security/code-scanning/494) Fixes elastic#1311 Escape first backslash occurrences and all single quotes in the `filter` string.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
…ng (elastic#204528) Fixes [https://github.com/elastic/kibana/security/code-scanning/494](https://github.com/elastic/kibana/security/code-scanning/494) Fixes elastic#1311 Escape first backslash occurrences and all single quotes in the `filter` string.
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
…ng (elastic#204528) Fixes [https://github.com/elastic/kibana/security/code-scanning/494](https://github.com/elastic/kibana/security/code-scanning/494) Fixes elastic#1311 Escape first backslash occurrences and all single quotes in the `filter` string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/elastic/kibana/security/code-scanning/494
Fixes #1311
Escape first backslash occurrences and all single quotes in the
filterstring.