[ECO][Inventory V2] Turn off entityCentricExperience feature flag by default #204278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion endpoint using sources (elastic#203424)" This reverts commit 5bacf1f.
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
…cexperience-feature-flag-by-default
|
@elasticmachine merge upstream |
|
There are no new commits on the base branch. |
…cexperience-feature-flag-by-default
…cexperience-feature-flag-by-default
|
To provide visibility on this, even with the Advanced Setting disabled by default, the Inventory plugin will appear in the feature visibility and user roles sections. This is because enabling the plugin through an Advanced Setting isn't directly tied to permissions.
|
…cexperience-feature-flag-by-default
…-feature-flag-by-default' of https://github.com/jennypavlova/kibana into 204238-ecoinventory-v2-turn-off-entitycentricexperience-feature-flag-by-default
…cexperience-feature-flag-by-default
…cexperience-feature-flag-by-default
kdelemme
approved these changes
Dec 16, 2024
| @@ -11,7 +11,7 @@ import { useKibanaContextForPlugin } from './use_kibana'; | |||
| export function useEntityCentricExperienceSetting() { | |||
| const { uiSettings } = useKibanaContextForPlugin().services; | |||
|
|
|||
| const isEntityCentricExperienceEnabled = uiSettings.get<boolean>(entityCentricExperience, true); | |||
| const isEntityCentricExperienceEnabled = uiSettings.get<boolean>(entityCentricExperience); | |||
There was a problem hiding this comment.
When not specified, default is false?
There was a problem hiding this comment.
Yes, it should be false by default.
…cexperience-feature-flag-by-default
…cexperience-feature-flag-by-default
…cexperience-feature-flag-by-default
…cexperience-feature-flag-by-default
…cexperience-feature-flag-by-default
…cexperience-feature-flag-by-default
…cexperience-feature-flag-by-default
…cexperience-feature-flag-by-default
iblancof
reviewed
Dec 17, 2024
x-pack/plugins/observability_solution/inventory/public/plugin.ts
Outdated
Show resolved
Hide resolved
…cexperience-feature-flag-by-default
…cexperience-feature-flag-by-default
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12379755631 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 17, 2024
…default (elastic#204278) Closes elastic#204238 ## Summary This PR turns off the`entityCentricExperience` feature flag by default | Before | After | | ------ | ------ | | <img width="1917" alt="image" src="https://github.com/user-attachments/assets/dbbe5b84-e16a-4578-8e67-1b3c31406da0" />| | | | <img width="343" alt="image" src="https://github.com/user-attachments/assets/66042e33-2cc9-4aa0-a9c7-e6a441141c08" /> | | | <img width="259" alt="image" src="https://github.com/user-attachments/assets/37f54dd4-a969-4882-ab41-d94381bc1b23" /> | |  | | ## Testing The `entityCentricExperience` feature flag should be turned off by default and the inventory menu item should not be visible. The inventory menu item should be visible if the flag is manually turned on. https://github.com/user-attachments/assets/7bee8ccb-bb29-451e-8a64-22325d9d8477 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co> (cherry picked from commit 62c99f7)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 18, 2024
…ag by default (#204278) (#204648) # Backport This will backport the following commits from `main` to `8.x`: - [[ECO][Inventory V2] Turn off entityCentricExperience feature flag by default (#204278)](#204278) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"dzheni.pavlova@elastic.co"},"sourceCommit":{"committedDate":"2024-12-17T19:09:37Z","message":"[ECO][Inventory V2] Turn off entityCentricExperience feature flag by default (#204278)\n\nCloses #204238 \r\n\r\n## Summary\r\n\r\nThis PR turns off the`entityCentricExperience` feature flag by default \r\n\r\n| Before | After |\r\n| ------ | ------ |\r\n| <img width=\"1917\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/dbbe5b84-e16a-4578-8e67-1b3c31406da0\"\r\n/>|\r\n|\r\n|\r\n|\r\n<img width=\"343\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/66042e33-2cc9-4aa0-a9c7-e6a441141c08\"\r\n/> |\r\n|\r\n|\r\n<img width=\"259\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/37f54dd4-a969-4882-ab41-d94381bc1b23\"\r\n/> |\r\n|\r\n\r\n|\r\n|\r\n\r\n## Testing\r\nThe `entityCentricExperience` feature flag should be turned off by\r\ndefault and the inventory menu item should not be visible. The inventory\r\nmenu item should be visible if the flag is manually turned on.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/7bee8ccb-bb29-451e-8a64-22325d9d8477\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Sergi Romeu <sergi.romeu@elastic.co>","sha":"62c99f73fdbf2649b75baf4d1fa3092850068c36","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management","v8.18.0"],"title":"[ECO][Inventory V2] Turn off entityCentricExperience feature flag by default","number":204278,"url":"https://github.com/elastic/kibana/pull/204278","mergeCommit":{"message":"[ECO][Inventory V2] Turn off entityCentricExperience feature flag by default (#204278)\n\nCloses #204238 \r\n\r\n## Summary\r\n\r\nThis PR turns off the`entityCentricExperience` feature flag by default \r\n\r\n| Before | After |\r\n| ------ | ------ |\r\n| <img width=\"1917\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/dbbe5b84-e16a-4578-8e67-1b3c31406da0\"\r\n/>|\r\n|\r\n|\r\n|\r\n<img width=\"343\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/66042e33-2cc9-4aa0-a9c7-e6a441141c08\"\r\n/> |\r\n|\r\n|\r\n<img width=\"259\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/37f54dd4-a969-4882-ab41-d94381bc1b23\"\r\n/> |\r\n|\r\n\r\n|\r\n|\r\n\r\n## Testing\r\nThe `entityCentricExperience` feature flag should be turned off by\r\ndefault and the inventory menu item should not be visible. The inventory\r\nmenu item should be visible if the flag is manually turned on.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/7bee8ccb-bb29-451e-8a64-22325d9d8477\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Sergi Romeu <sergi.romeu@elastic.co>","sha":"62c99f73fdbf2649b75baf4d1fa3092850068c36"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204278","number":204278,"mergeCommit":{"message":"[ECO][Inventory V2] Turn off entityCentricExperience feature flag by default (#204278)\n\nCloses #204238 \r\n\r\n## Summary\r\n\r\nThis PR turns off the`entityCentricExperience` feature flag by default \r\n\r\n| Before | After |\r\n| ------ | ------ |\r\n| <img width=\"1917\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/dbbe5b84-e16a-4578-8e67-1b3c31406da0\"\r\n/>|\r\n|\r\n|\r\n|\r\n<img width=\"343\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/66042e33-2cc9-4aa0-a9c7-e6a441141c08\"\r\n/> |\r\n|\r\n|\r\n<img width=\"259\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/37f54dd4-a969-4882-ab41-d94381bc1b23\"\r\n/> |\r\n|\r\n\r\n|\r\n|\r\n\r\n## Testing\r\nThe `entityCentricExperience` feature flag should be turned off by\r\ndefault and the inventory menu item should not be visible. The inventory\r\nmenu item should be visible if the flag is manually turned on.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/7bee8ccb-bb29-451e-8a64-22325d9d8477\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Sergi Romeu <sergi.romeu@elastic.co>","sha":"62c99f73fdbf2649b75baf4d1fa3092850068c36"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co> Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Dec 19, 2024
…default (elastic#204278) Closes elastic#204238 ## Summary This PR turns off the`entityCentricExperience` feature flag by default | Before | After | | ------ | ------ | | <img width="1917" alt="image" src="https://github.com/user-attachments/assets/dbbe5b84-e16a-4578-8e67-1b3c31406da0" />| | | | <img width="343" alt="image" src="https://github.com/user-attachments/assets/66042e33-2cc9-4aa0-a9c7-e6a441141c08" /> | | | <img width="259" alt="image" src="https://github.com/user-attachments/assets/37f54dd4-a969-4882-ab41-d94381bc1b23" /> | |  | | ## Testing The `entityCentricExperience` feature flag should be turned off by default and the inventory menu item should not be visible. The inventory menu item should be visible if the flag is manually turned on. https://github.com/user-attachments/assets/7bee8ccb-bb29-451e-8a64-22325d9d8477 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Jan 2, 2025
…default (elastic#204278) Closes elastic#204238 ## Summary This PR turns off the`entityCentricExperience` feature flag by default | Before | After | | ------ | ------ | | <img width="1917" alt="image" src="https://github.com/user-attachments/assets/dbbe5b84-e16a-4578-8e67-1b3c31406da0" />| | | | <img width="343" alt="image" src="https://github.com/user-attachments/assets/66042e33-2cc9-4aa0-a9c7-e6a441141c08" /> | | | <img width="259" alt="image" src="https://github.com/user-attachments/assets/37f54dd4-a969-4882-ab41-d94381bc1b23" /> | |  | | ## Testing The `entityCentricExperience` feature flag should be turned off by default and the inventory menu item should not be visible. The inventory menu item should be visible if the flag is manually turned on. https://github.com/user-attachments/assets/7bee8ccb-bb29-451e-8a64-22325d9d8477 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
…default (elastic#204278) Closes elastic#204238 ## Summary This PR turns off the`entityCentricExperience` feature flag by default | Before | After | | ------ | ------ | | <img width="1917" alt="image" src="https://github.com/user-attachments/assets/dbbe5b84-e16a-4578-8e67-1b3c31406da0" />| | | | <img width="343" alt="image" src="https://github.com/user-attachments/assets/66042e33-2cc9-4aa0-a9c7-e6a441141c08" /> | | | <img width="259" alt="image" src="https://github.com/user-attachments/assets/37f54dd4-a969-4882-ab41-d94381bc1b23" /> | |  | | ## Testing The `entityCentricExperience` feature flag should be turned off by default and the inventory menu item should not be visible. The inventory menu item should be visible if the flag is manually turned on. https://github.com/user-attachments/assets/7bee8ccb-bb29-451e-8a64-22325d9d8477 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
…default (elastic#204278) Closes elastic#204238 ## Summary This PR turns off the`entityCentricExperience` feature flag by default | Before | After | | ------ | ------ | | <img width="1917" alt="image" src="https://github.com/user-attachments/assets/dbbe5b84-e16a-4578-8e67-1b3c31406da0" />| | | | <img width="343" alt="image" src="https://github.com/user-attachments/assets/66042e33-2cc9-4aa0-a9c7-e6a441141c08" /> | | | <img width="259" alt="image" src="https://github.com/user-attachments/assets/37f54dd4-a969-4882-ab41-d94381bc1b23" /> | |  | | ## Testing The `entityCentricExperience` feature flag should be turned off by default and the inventory menu item should not be visible. The inventory menu item should be visible if the flag is manually turned on. https://github.com/user-attachments/assets/7bee8ccb-bb29-451e-8a64-22325d9d8477 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #204238
Summary
This PR turns off the
entityCentricExperiencefeature flag by defaultTesting
The
entityCentricExperiencefeature flag should be turned off by default and the inventory menu item should not be visible. The inventory menu item should be visible if the flag is manually turned on.ff_entities_off.on.mov