Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps][Rules] Delete legacy routes #203148

Merged
merged 15 commits into from
Dec 16, 2024
Merged

[ResponseOps][Rules] Delete legacy routes #203148

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
dc0c752
remove legacy routes
js-jankisalvi Dec 5, 2024
e6e3a72
remove legacy tests, update legacy paths to working api paths from fu…
js-jankisalvi Dec 9, 2024
7552e6a
Merge branch 'main' into remove-deprecated-rule-apis
js-jankisalvi Dec 9, 2024
8e196fa
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Dec 9, 2024
032d05f
fix linting
js-jankisalvi Dec 9, 2024
86d61ff
Merge branch 'remove-deprecated-rule-apis' of https://github.com/js-j…
js-jankisalvi Dec 9, 2024
7bd7e87
fix failing tests
js-jankisalvi Dec 9, 2024
b114d30
fix connector and uptime test
js-jankisalvi Dec 10, 2024
b0777a9
fix camelCase lint
js-jankisalvi Dec 10, 2024
753a323
fix last test, update docs
js-jankisalvi Dec 12, 2024
3aef5cc
Merge branch 'main' into remove-deprecated-rule-apis
js-jankisalvi Dec 12, 2024
693c502
[CI] Auto-commit changed files from 'make api-docs'
kibanamachine Dec 12, 2024
9be00e5
Merge remote-tracking branch 'upstream/main' into remove-deprecated-r…
js-jankisalvi Dec 13, 2024
edd060c
Merge branch 'main' into remove-deprecated-rule-apis
js-jankisalvi Dec 16, 2024
bbfb545
Merge branch 'main' into remove-deprecated-rule-apis
js-jankisalvi Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/plugins/discover/public/application/view_alert/view_alert_utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export interface QueryParams {
to: string | null;
}

const LEGACY_BASE_ALERT_API_PATH = '/api/alerts';
const BASE_ALERTING_API_PATH = '/api/alerting';

const buildTimeRangeFilter = (
dataView: DataView,
Expand Down Expand Up @@ -77,7 +77,7 @@ export const getAlertUtils = (
const fetchAlert = async (id: string) => {
try {
return await core.http.get<Rule<SearchThresholdAlertParams>>(
`${LEGACY_BASE_ALERT_API_PATH}/alert/${id}`
`${BASE_ALERTING_API_PATH}/rule/${id}`
);
} catch (error) {
const errorTitle = i18n.translate('discover.viewAlert.alertRuleFetchErrorTitle', {
Expand Down
Loading