Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add limit to Discover ES|QL queries to remove deprecation warnings #202735

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Add limit to Discover ES|QL queries to remove deprecation warnings #202735

merged 4 commits into from
Dec 11, 2024

Conversation

lukasolson
Copy link
Member

@lukasolson lukasolson commented Dec 3, 2024 •
edited by kibanamachine
Loading

Summary

Resolves #196491.

Adds a LIMIT to our ES|QL Discover tests. Without the LIMIT we are getting the following deprecation messages:

Elasticsearch deprecation: 299 Elasticsearch-9.0.0-c74c06daee0583562c82597b19178268b9f415e5 "No limit defined, adding default limit of [1000]"

Checklist

@lukasolson lukasolson added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Dec 3, 2024
@lukasolson lukasolson self-assigned this Dec 3, 2024
@lukasolson lukasolson marked this pull request as ready for review December 10, 2024 16:19
@lukasolson lukasolson requested a review from a team as a code owner December 10, 2024 16:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@lukasolson lukasolson added the backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) label Dec 10, 2024
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @lukasolson

davismcphee
davismcphee approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing it!

@lukasolson lukasolson merged commit 162b149 into elastic:main Dec 11, 2024
11 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12277198826

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 11, 2024
@lukasolson
Add limit to Discover ES|QL queries to remove deprecation warnings (e…
675b276 
…lastic#202735)

## Summary

Resolves elastic#196491.

Adds a `LIMIT` to our ES|QL Discover tests. Without the `LIMIT` we are
getting the following deprecation messages:

> Elasticsearch deprecation: 299
Elasticsearch-9.0.0-c74c06daee0583562c82597b19178268b9f415e5 "No limit
defined, adding default limit of [1000]"

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 162b149)
@kibanamachine kibanamachine mentioned this pull request Dec 11, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 11, 2024
@kibanamachine @lukasolson
[8.x] Add limit to Discover ES|QL queries to remove deprecation warni…
bb24e2c 
…ngs (#202735) (#203797)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Add limit to Discover ES|QL queries to remove deprecation warnings
(#202735)](#202735)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lukas
Olson","email":"lukas@elastic.co"},"sourceCommit":{"committedDate":"2024-12-11T13:18:11Z","message":"Add
limit to Discover ES|QL queries to remove deprecation warnings
(#202735)\n\n## Summary\r\n\r\nResolves
https://github.com/elastic/kibana/issues/196491.\r\n\r\nAdds a `LIMIT`
to our ES|QL Discover tests. Without the `LIMIT` we are\r\ngetting the
following deprecation messages:\r\n\r\n> Elasticsearch deprecation:
299\r\nElasticsearch-9.0.0-c74c06daee0583562c82597b19178268b9f415e5 \"No
limit\r\ndefined, adding default limit of [1000]\"\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"162b1497b97391b63f78cc6b35a544b45641e66b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor"],"title":"Add
limit to Discover ES|QL queries to remove deprecation
warnings","number":202735,"url":"https://github.com/elastic/kibana/pull/202735","mergeCommit":{"message":"Add
limit to Discover ES|QL queries to remove deprecation warnings
(#202735)\n\n## Summary\r\n\r\nResolves
https://github.com/elastic/kibana/issues/196491.\r\n\r\nAdds a `LIMIT`
to our ES|QL Discover tests. Without the `LIMIT` we are\r\ngetting the
following deprecation messages:\r\n\r\n> Elasticsearch deprecation:
299\r\nElasticsearch-9.0.0-c74c06daee0583562c82597b19178268b9f415e5 \"No
limit\r\ndefined, adding default limit of [1000]\"\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"162b1497b97391b63f78cc6b35a544b45641e66b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202735","number":202735,"mergeCommit":{"message":"Add
limit to Discover ES|QL queries to remove deprecation warnings
(#202735)\n\n## Summary\r\n\r\nResolves
https://github.com/elastic/kibana/issues/196491.\r\n\r\nAdds a `LIMIT`
to our ES|QL Discover tests. Without the `LIMIT` we are\r\ngetting the
following deprecation messages:\r\n\r\n> Elasticsearch deprecation:
299\r\nElasticsearch-9.0.0-c74c06daee0583562c82597b19178268b9f415e5 \"No
limit\r\ndefined, adding default limit of [1000]\"\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"162b1497b97391b63f78cc6b35a544b45641e66b"}}]}]
BACKPORT-->

Co-authored-by: Lukas Olson <lukas@elastic.co>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@lukasolson @CAWilson94
Add limit to Discover ES|QL queries to remove deprecation warnings (e…
dd1ef40 
…lastic#202735)

## Summary

Resolves elastic#196491.

Adds a `LIMIT` to our ES|QL Discover tests. Without the `LIMIT` we are
getting the following deprecation messages:

> Elasticsearch deprecation: 299
Elasticsearch-9.0.0-c74c06daee0583562c82597b19178268b9f415e5 "No limit
defined, adding default limit of [1000]"

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
@lukasolson @CAWilson94
Add limit to Discover ES|QL queries to remove deprecation warnings (e…
36264ae 
…lastic#202735)

## Summary

Resolves elastic#196491.

Adds a `LIMIT` to our ES|QL Discover tests. Without the `LIMIT` we are
getting the following deprecation messages:

> Elasticsearch deprecation: 299
Elasticsearch-9.0.0-c74c06daee0583562c82597b19178268b9f415e5 "No limit
defined, adding default limit of [1000]"

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davismcphee davismcphee davismcphee approved these changes

Assignees

@lukasolson lukasolson

Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor deprecated ES API usage
4 participants
@lukasolson @elasticmachine @kibanamachine @davismcphee