Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EUI Visual Refresh][Security Gen AI] Add support for borealis theme #202393

Merged
merged 19 commits into from
Jan 14, 2025
Merged

[EUI Visual Refresh][Security Gen AI] Add support for borealis theme #202393

merged 19 commits into from
Jan 14, 2025
+151 −108

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Dec 1, 2024 •
edited by kibanamachine
Loading

Summary

Zrzut ekranu 2025-01-8 o 18 33 20

@KDKHD KDKHD mentioned this pull request Dec 2, 2024
Merged
2 tasks
@mgadewoll mgadewoll added the backport:skip This commit does not require backporting label Dec 12, 2024
@patrykkopycinski
Copy link
Contributor Author

/ci

@patrykkopycinski
Copy link
Contributor Author

/ci

@patrykkopycinski patrykkopycinski changed the title Add support for borealis theme [EUI Visual Refresh][Security Gen AI] Add support for borealis theme Jan 8, 2025
@patrykkopycinski patrykkopycinski marked this pull request as ready for review January 8, 2025 19:35
@patrykkopycinski patrykkopycinski requested review from a team as code owners January 8, 2025 19:35
@patrykkopycinski patrykkopycinski requested a review from xcrzx January 8, 2025 19:35
mgadewoll
mgadewoll reviewed Jan 9, 2025
View reviewed changes
...orm/packages/shared/kbn-elastic-assistant/impl/data_anonymization_editor/context_preview.tsx
import { css } from '@emotion/react';
import { AnonymizedData } from '@kbn/elastic-assistant-common/impl/data_anonymization/types';
import styled from '@emotion/styled';
import { SelectedPromptContext } from '../assistant/prompt_context/types';

const Strong = styled.strong<{ showRealValues: boolean }>`
color: ${(props) =>
props.showRealValues ? euiThemeVars.euiColorSuccess : euiThemeVars.euiColorAccent};
props.showRealValues
? props.theme.euiTheme.colors.textPrimary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Is this an intentional change from success to primary? (This will affect Amsterdam as well)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's used in this context, so I believe primary better serves the purpose:
before changes (success):
image
after changes (textPrimary):
image
toggled (textAccent):
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@james-elastic @bojanasan are you ok with this change? (green -> blue text color)
the change was introduced due to #199715 (comment)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patrykkopycinski all good on my end, I agree that think it makes more sense to use the primary color instead of success for anonymization strings.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ good with me.

mgadewoll
mgadewoll approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Changes LGTM from EUI side.

@patrykkopycinski patrykkopycinski self-assigned this Jan 10, 2025
@patrykkopycinski patrykkopycinski added release_note:skip Skip the PR/issue when compiling release notes Feature:Security Assistant Security Assistant Team:Security Generative AI Security Generative AI labels Jan 10, 2025
e40pud
e40pud approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@e40pud e40pud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a small comment

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts / Serverless Observability - Deployment-agnostic API integration tests observability AI Assistant When there are knowledge base entries (from 8.15 or earlier) that does not contain semantic_text embeddings "after all" hook in "When there are knowledge base entries (from 8.15 or earlier) that does not contain semantic_text embeddings"
  • [job] [logs] x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts / Serverless Observability - Deployment-agnostic API integration tests observability AI Assistant When there are knowledge base entries (from 8.15 or earlier) that does not contain semantic_text embeddings "before all" hook in "When there are knowledge base entries (from 8.15 or earlier) that does not contain semantic_text embeddings"
  • [job] [logs] Jest Integration Tests #4 / StorageIndexAdapter when indexing into a clean Elasticsearch instance after rolling over the index manually and indexing the same document deletes the document from the rolled over index
  • [job] [logs] Jest Integration Tests #4 / StorageIndexAdapter when indexing into a clean Elasticsearch instance after rolling over the index manually and indexing the same document puts the document in the new write index

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 21.2MB 21.2MB +223.0B

History

cc @patrykkopycinski

@patrykkopycinski patrykkopycinski added v9.0.0 backport:version Backport to applied version labels v8.18.0 and removed backport:skip This commit does not require backporting labels Jan 14, 2025
@patrykkopycinski patrykkopycinski merged commit 760d6fe into elastic:main Jan 14, 2025
15 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12773075096

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 14, 2025
@patrykkopycinski
[EUI Visual Refresh][Security Gen AI] Add support for borealis theme (e…
13ca061 
…lastic#202393)

## Summary

<img width="3003" alt="Zrzut ekranu 2025-01-8 o 18 33 20"
src="https://github.com/user-attachments/assets/4bc2f0f4-74f6-439b-b3dc-2c8e5182321b"
/>

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 760d6fe)
@kibanamachine kibanamachine mentioned this pull request Jan 14, 2025
Closed
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@patrykkopycinski patrykkopycinski added backport:skip This commit does not require backporting and removed backport:version Backport to applied version labels labels Jan 14, 2025
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
@patrykkopycinski @kibanamachine @viduni94
[EUI Visual Refresh][Security Gen AI] Add support for borealis theme (e…
d572f66 
…lastic#202393)

## Summary

<img width="3003" alt="Zrzut ekranu 2025-01-8 o 18 33 20"
src="https://github.com/user-attachments/assets/4bc2f0f4-74f6-439b-b3dc-2c8e5182321b"
/>

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Jan 29, 2025
Merged
9 tasks
kapral18 added a commit to kibanamachine/kibana that referenced this pull request Feb 11, 2025
@kapral18
chore: resolve snapshot update issue caused by missing backport
8c4ace8 
caused by missing backport from elastic#202393
kapral18 added a commit to kibanamachine/kibana that referenced this pull request Feb 11, 2025
@kapral18
chore: resolve snapshot update issue caused by missing backport
1922cbd 
caused by missing backport from elastic#202393
kapral18 added a commit to kapral18/kibana that referenced this pull request Feb 11, 2025
@kapral18
chore: resolve snapshot update issue caused by missing backport
6787ef6 
caused by missing backport from elastic#202393
@kibanamachine kibanamachine mentioned this pull request Feb 21, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bojanasan bojanasan bojanasan left review comments

@jamesspi jamesspi jamesspi left review comments

@xcrzx xcrzx xcrzx approved these changes

@e40pud e40pud e40pud approved these changes

@mgadewoll mgadewoll mgadewoll approved these changes

@JasonStoltz JasonStoltz Awaiting requested review from JasonStoltz

Assignees

@patrykkopycinski patrykkopycinski

Labels
backport:skip This commit does not require backporting EUI Visual Refresh Feature:Security Assistant Security Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Security Generative AI Security Generative AI v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@patrykkopycinski @elasticmachine @kibanamachine @bojanasan @xcrzx @e40pud @jamesspi @mgadewoll @JasonStoltz