Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Fix gauge responsive overflow and test unskip #202323

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Nov 29, 2024

Summary

Fixing the missing overflow in Major Arc/Circle gauge.
Unskipped tests.

close #193548
fix #193946
close #202174
relates to https://github.com/elastic/kibana-operations/issues/199

@markov00 markov00 added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) FTR labels Nov 29, 2024
@markov00 markov00 marked this pull request as ready for review November 29, 2024 17:26
@markov00 markov00 requested a review from a team as a code owner November 29, 2024 17:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@dej611
Copy link
Contributor

dej611 commented Dec 2, 2024

Would you mind add a flaky test run?

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 2, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [9b99070]

History

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7540

[✅] x-pack/test/functional/apps/lens/group6/config.ts: 200/200 tests passed.

see run history

@markov00 markov00 merged commit 526ef51 into elastic:main Dec 2, 2024
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12123476626

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 2, 2024
## Summary

Fixing the missing overflow in Major Arc/Circle gauge.
Unskipped tests.

close elastic#193548
fix elastic#193946
close elastic#202174
relates to elastic/kibana-operations#199

(cherry picked from commit 526ef51)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 2, 2024
…202530)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Lens] Fix gauge responsive overflow and test unskip
(#202323)](#202323)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marco
Vettorello","email":"marco.vettorello@elastic.co"},"sourceCommit":{"committedDate":"2024-12-02T16:18:39Z","message":"[Lens]
Fix gauge responsive overflow and test unskip (#202323)\n\n##
Summary\r\n\r\nFixing the missing overflow in Major Arc/Circle
gauge.\r\nUnskipped tests.\r\n\r\nclose
https://github.com/elastic/kibana/issues/193548\r\nfix
https://github.com/elastic/kibana/issues/193946\r\nclose
https://github.com/elastic/kibana/issues/202174\r\nrelates to
https://github.com/elastic/kibana-operations/issues/199","sha":"526ef51a12f450b353cb35d432bf0068dc4e6fc7","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Visualizations","release_note:skip","v9.0.0","backport:prev-minor","FTR"],"title":"[Lens]
Fix gauge responsive overflow and test
unskip","number":202323,"url":"https://github.com/elastic/kibana/pull/202323","mergeCommit":{"message":"[Lens]
Fix gauge responsive overflow and test unskip (#202323)\n\n##
Summary\r\n\r\nFixing the missing overflow in Major Arc/Circle
gauge.\r\nUnskipped tests.\r\n\r\nclose
https://github.com/elastic/kibana/issues/193548\r\nfix
https://github.com/elastic/kibana/issues/193946\r\nclose
https://github.com/elastic/kibana/issues/202174\r\nrelates to
https://github.com/elastic/kibana-operations/issues/199","sha":"526ef51a12f450b353cb35d432bf0068dc4e6fc7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202323","number":202323,"mergeCommit":{"message":"[Lens]
Fix gauge responsive overflow and test unskip (#202323)\n\n##
Summary\r\n\r\nFixing the missing overflow in Major Arc/Circle
gauge.\r\nUnskipped tests.\r\n\r\nclose
https://github.com/elastic/kibana/issues/193548\r\nfix
https://github.com/elastic/kibana/issues/193946\r\nclose
https://github.com/elastic/kibana/issues/202174\r\nrelates to
https://github.com/elastic/kibana-operations/issues/199","sha":"526ef51a12f450b353cb35d432bf0068dc4e6fc7"}}]}]
BACKPORT-->

Co-authored-by: Marco Vettorello <marco.vettorello@elastic.co>
@markov00 markov00 deleted the 2024_11_29-fix_gauge_size branch December 3, 2024 09:03
hop-dev pushed a commit to hop-dev/kibana that referenced this pull request Dec 5, 2024
## Summary

Fixing the missing overflow in Major Arc/Circle gauge.
Unskipped tests.

close elastic#193548
fix elastic#193946
close elastic#202174
relates to elastic/kibana-operations#199
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
## Summary

Fixing the missing overflow in Major Arc/Circle gauge.
Unskipped tests.

close elastic#193548
fix elastic#193946
close elastic#202174
relates to elastic/kibana-operations#199
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
## Summary

Fixing the missing overflow in Major Arc/Circle gauge.
Unskipped tests.

close elastic#193548
fix elastic#193946
close elastic#202174
relates to elastic/kibana-operations#199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) bug Fixes for quality problems that affect the customer experience FTR release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.18.0 v9.0.0
Projects
None yet
4 participants