Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Beta Ceph metrics module to Kibana Home #20223

Merged
merged 4 commits into from
Jul 16, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions src/core_plugins/kibana/server/tutorials/ceph_metrics/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
/*
* Licensed to Elasticsearch B.V. under one or more contributor
* license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright
* ownership. Elasticsearch B.V. licenses this file to you under
* the Apache License, Version 2.0 (the "License"); you may
* not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

import { TUTORIAL_CATEGORY } from '../../../common/tutorials/tutorial_category';
import { onPremInstructions, cloudInstructions, onPremCloudInstructions } from '../../../common/tutorials/metricbeat_instructions';

export function cephMetricsSpecProvider() {
const moduleName = 'ceph';
return {
id: 'cephMetrics',
name: 'Ceph metrics',
isBeta: true,
category: TUTORIAL_CATEGORY.METRICS,
shortDescription: 'Fetch internal metrics from the Ceph server.',
longDescription: 'The `ceph` Metricbeat module fetches internal metrics from Ceph.' +
' [Learn more]({config.docs.beats.metricbeat}/metricbeat-module-ceph.html).',
artifacts: {
application: {
label: 'Discover',
path: '/app/kibana#/discover'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsg @alexfrancoeur I'm jumping here now to the discovery page. I was thinking if we should jump to discovery and already filter for the data from the module?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option is to leave that out and then there is simply no button at the end. But I think Discover is not bad.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this at first but it feels awkward as the user kind of gets stuck. Everything is complete, what now? Will move forward with discover for now and can still improve it in the future.

},
dashboards: [],
exportedFields: {
documentationUrl: '{config.docs.beats.metricbeat}/exported-fields-ceph.html'
}
},
completionTimeMinutes: 10,
onPrem: onPremInstructions(moduleName),
elasticCloud: cloudInstructions(moduleName),
onPremElasticCloud: onPremCloudInstructions(moduleName)
};
}
2 changes: 2 additions & 0 deletions src/core_plugins/kibana/server/tutorials/register.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ import { dockerMetricsSpecProvider } from './docker_metrics';
import { kubernetesMetricsSpecProvider } from './kubernetes_metrics';
import { netflowSpecProvider } from './netflow';
import { apmSpecProvider } from './apm';
import { cephMetricsSpecProvider } from './ceph_metrics';

export function registerTutorials(server) {
server.registerTutorial(systemLogsSpecProvider);
Expand All @@ -55,4 +56,5 @@ export function registerTutorials(server) {
server.registerTutorial(kubernetesMetricsSpecProvider);
server.registerTutorial(netflowSpecProvider);
server.registerTutorial(apmSpecProvider);
server.registerTutorial(cephMetricsSpecProvider);
}