[Search][ES3] Make Connector config a copyable codeblock #201949
Conversation
| <EuiSpacer /> | ||
| {status === ConnectorStatus.CREATED ? ( | ||
| {Boolean(serviceType) && | ||
| (status === ConnectorStatus.CREATED || status === ConnectorStatus.NEEDS_CONFIGURATION) ? ( |
There was a problem hiding this comment.
This change confuses me a little. Are we sure this is correct? We've had issues where we get people stuck at a step in this logic.
There was a problem hiding this comment.
After the service type is selected, the connector status becomes needs_configuration despite not being connected yet. Because of that, the Waiting for connection card disappears even though the Connector hasn't checked in yet. If you try it on prod now you'll see that the card disappears when it shouldn't.
I think the Boolean(serviceType) could be removed, I just didn't want two of the yellow cards to appear at the bottom at the same time ("select connector type" and "waiting for connection")
There was a problem hiding this comment.
Here's a gif of how it works right now on main. Notice that the "waiting for connection" card disappears despite the connector not being connected yet (all I've done is selected a service type).
Summary
Make the configuration for Connectors a copyable codeblock during create a connector flow.