Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Clean code related to savedObjectClientContrat that wasn't being used (#200629) #200859

Merged
merged 1 commit into from
Nov 20, 2024
Merged

[8.x] Clean code related to savedObjectClientContrat that wasn't being used (#200629) #200859

merged 1 commit into from
Nov 20, 2024

Conversation

jesuswr
Copy link
Contributor

@jesuswr jesuswr commented Nov 20, 2024

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@jesuswr
Clean code related to savedObjectClientContrat that wasn't being used (…
69aff2c 
…elastic#200629)

## Summary

Resolves: elastic#197216

Removed all code that wasn't being used in
https://github.com/elastic/kibana/tree/main/src/plugins/saved_objects/public.
Didn't remove the actual client since it's still being used here:
https://github.com/elastic/kibana/blob/dbab2214e9451d3a262007660cc0b7cdcea5307c/src/plugins/home/public/application/kibana_services.ts#L46-L48

Checked everything with `node scripts/type_check`

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_node:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit d900299)

# Conflicts:
#	x-pack/plugins/translations/translations/zh-CN.json
@jesuswr jesuswr enabled auto-merge (squash) November 20, 2024 08:11
@jesuswr jesuswr mentioned this pull request Nov 20, 2024
Merged
1 task
@jesuswr jesuswr merged commit 600d6d0 into elastic:8.x Nov 20, 2024
24 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
savedObjects 42 36 -6

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
savedObjects 109 96 -13

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
savedObjects 5 3 -2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
savedObjects 19.6KB 17.6KB -2.0KB
Unknown metric groups

API count

id before after diff
savedObjects 114 97 -17

References to deprecated APIs

id before after diff
savedObjects 62 11 -51

@jesuswr jesuswr deleted the backport/8.x/pr-200629 branch November 20, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jesuswr @elasticmachine @afharo