Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky test - counts dashboard views #197381

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Oct 23, 2024

Summary

fix #192564

It might take a bit of time for the view count to update. So in the test we will try to open the flyout again

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7217

[❌] test/functional/apps/dashboard/group4/config.ts: 25/50 tests passed.

see run history

@Dosant Dosant changed the title only fix failing test - listing page insights shows the insights panel and counts the views Oct 23, 2024
@Dosant Dosant changed the title fix failing test - listing page insights shows the insights panel and counts the views fix failing test - the insights panel and counts the views Oct 23, 2024
@Dosant Dosant changed the title fix failing test - the insights panel and counts the views fix flaky test - the insights panel and counts the views Oct 23, 2024
@Dosant Dosant changed the title fix flaky test - the insights panel and counts the views fix flaky test - insights panel counts the views Oct 23, 2024
@Dosant Dosant changed the title fix flaky test - insights panel counts the views fix flaky test - counts dashboard views Oct 23, 2024
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7230

[✅] test/functional/apps/dashboard/group4/config.ts: 50/50 tests passed.

see run history

@Dosant Dosant added release_note:skip Skip the PR/issue when compiling release notes v8.16.0 backport:version Backport to applied version labels v8.17.0 Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Oct 24, 2024
@Dosant Dosant marked this pull request as ready for review October 24, 2024 09:21
@Dosant Dosant requested a review from a team as a code owner October 24, 2024 09:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@Dosant Dosant enabled auto-merge (squash) October 24, 2024 09:32
@Dosant
Copy link
Contributor Author

Dosant commented Oct 24, 2024

@elasticmachine merge upstream

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
code review and tested case with 3G network speed throttling and insights first shows with previous value and then updates to new value as test now accounts for. Thanks for fixing

@Dosant Dosant merged commit 3684ded into elastic:main Oct 24, 2024
21 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11500303962

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 24, 2024
## Summary

fix elastic#192564

It might take a bit of time for the view count to update. So in the test
we will try to open the flyout again

(cherry picked from commit 3684ded)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 24, 2024
## Summary

fix elastic#192564

It might take a bit of time for the view count to update. So in the test
we will try to open the flyout again

(cherry picked from commit 3684ded)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.16
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 24, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [fix flaky test - counts dashboard views
(#197381)](#197381)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Anton
Dosov","email":"anton.dosov@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T13:27:04Z","message":"fix
flaky test - counts dashboard views (#197381)\n\n## Summary\r\n\r\nfix
https://github.com/elastic/kibana/issues/192564\r\n\r\nIt might take a
bit of time for the view count to update. So in the test\r\nwe will try
to open the flyout
again","sha":"3684dedecb001291f857a1649e721c1e4e6b22e7","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","v8.16.0","backport:version","v8.17.0"],"title":"fix
flaky test - counts dashboard
views","number":197381,"url":"https://github.com/elastic/kibana/pull/197381","mergeCommit":{"message":"fix
flaky test - counts dashboard views (#197381)\n\n## Summary\r\n\r\nfix
https://github.com/elastic/kibana/issues/192564\r\n\r\nIt might take a
bit of time for the view count to update. So in the test\r\nwe will try
to open the flyout
again","sha":"3684dedecb001291f857a1649e721c1e4e6b22e7"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197381","number":197381,"mergeCommit":{"message":"fix
flaky test - counts dashboard views (#197381)\n\n## Summary\r\n\r\nfix
https://github.com/elastic/kibana/issues/192564\r\n\r\nIt might take a
bit of time for the view count to update. So in the test\r\nwe will try
to open the flyout
again","sha":"3684dedecb001291f857a1649e721c1e4e6b22e7"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
kibanamachine added a commit that referenced this pull request Oct 24, 2024
# Backport

This will backport the following commits from `main` to `8.16`:
- [fix flaky test - counts dashboard views
(#197381)](#197381)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Anton
Dosov","email":"anton.dosov@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T13:27:04Z","message":"fix
flaky test - counts dashboard views (#197381)\n\n## Summary\r\n\r\nfix
https://github.com/elastic/kibana/issues/192564\r\n\r\nIt might take a
bit of time for the view count to update. So in the test\r\nwe will try
to open the flyout
again","sha":"3684dedecb001291f857a1649e721c1e4e6b22e7","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","v8.16.0","backport:version","v8.17.0"],"title":"fix
flaky test - counts dashboard
views","number":197381,"url":"https://github.com/elastic/kibana/pull/197381","mergeCommit":{"message":"fix
flaky test - counts dashboard views (#197381)\n\n## Summary\r\n\r\nfix
https://github.com/elastic/kibana/issues/192564\r\n\r\nIt might take a
bit of time for the view count to update. So in the test\r\nwe will try
to open the flyout
again","sha":"3684dedecb001291f857a1649e721c1e4e6b22e7"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197381","number":197381,"mergeCommit":{"message":"fix
flaky test - counts dashboard views (#197381)\n\n## Summary\r\n\r\nfix
https://github.com/elastic/kibana/issues/192564\r\n\r\nIt might take a
bit of time for the view count to update. So in the test\r\nwe will try
to open the flyout
again","sha":"3684dedecb001291f857a1649e721c1e4e6b22e7"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Dosant added a commit that referenced this pull request Feb 19, 2025
## Summary

close #192564

I thought I fixed this earlier, but looks like I forget to unskip 😮‍💨
#197381
This is another attempt
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 19, 2025
## Summary

close elastic#192564

I thought I fixed this earlier, but looks like I forget to unskip 😮‍💨
elastic#197381
This is another attempt

(cherry picked from commit 97ee552)
kibanamachine added a commit that referenced this pull request Feb 19, 2025
# Backport

This will backport the following commits from `main` to `9.0`:
- [unskip dashboard_listing
(#211742)](#211742)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Anton
Dosov","email":"anton.dosov@elastic.co"},"sourceCommit":{"committedDate":"2025-02-19T15:42:26Z","message":"unskip
dashboard_listing (#211742)\n\n## Summary\n\nclose
https://github.com/elastic/kibana/issues/192564\n\nI thought I fixed
this earlier, but looks like I forget to unskip
😮‍💨\nhttps://github.com//pull/197381\nThis is another
attempt","sha":"97ee552d0ffa025c0d7b8032384c4a5b5513a495","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","v9.1.0"],"title":"unskip
dashboard_listing","number":211742,"url":"https://github.com/elastic/kibana/pull/211742","mergeCommit":{"message":"unskip
dashboard_listing (#211742)\n\n## Summary\n\nclose
https://github.com/elastic/kibana/issues/192564\n\nI thought I fixed
this earlier, but looks like I forget to unskip
😮‍💨\nhttps://github.com//pull/197381\nThis is another
attempt","sha":"97ee552d0ffa025c0d7b8032384c4a5b5513a495"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211742","number":211742,"mergeCommit":{"message":"unskip
dashboard_listing (#211742)\n\n## Summary\n\nclose
https://github.com/elastic/kibana/issues/192564\n\nI thought I fixed
this earlier, but looks like I forget to unskip
😮‍💨\nhttps://github.com//pull/197381\nThis is another
attempt","sha":"97ee552d0ffa025c0d7b8032384c4a5b5513a495"}}]}]
BACKPORT-->

Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.16.0 v8.17.0 v9.0.0
Projects
None yet
4 participants