-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix flaky test - counts dashboard views #197381
Conversation
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7217[❌] test/functional/apps/dashboard/group4/config.ts: 25/50 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7230[✅] test/functional/apps/dashboard/group4/config.ts: 50/50 tests passed. |
Pinging @elastic/appex-sharedux (Team:SharedUX) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
code review and tested case with 3G
network speed throttling and insights first shows with previous value and then updates to new value as test now accounts for. Thanks for fixing
Starting backport for target branches: 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11500303962 |
💚 Build Succeeded
Metrics [docs]
History
|
## Summary fix elastic#192564 It might take a bit of time for the view count to update. So in the test we will try to open the flyout again (cherry picked from commit 3684ded)
## Summary fix elastic#192564 It might take a bit of time for the view count to update. So in the test we will try to open the flyout again (cherry picked from commit 3684ded)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.x`: - [fix flaky test - counts dashboard views (#197381)](#197381) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Anton Dosov","email":"anton.dosov@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T13:27:04Z","message":"fix flaky test - counts dashboard views (#197381)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/192564\r\n\r\nIt might take a bit of time for the view count to update. So in the test\r\nwe will try to open the flyout again","sha":"3684dedecb001291f857a1649e721c1e4e6b22e7","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","v8.16.0","backport:version","v8.17.0"],"title":"fix flaky test - counts dashboard views","number":197381,"url":"https://github.com/elastic/kibana/pull/197381","mergeCommit":{"message":"fix flaky test - counts dashboard views (#197381)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/192564\r\n\r\nIt might take a bit of time for the view count to update. So in the test\r\nwe will try to open the flyout again","sha":"3684dedecb001291f857a1649e721c1e4e6b22e7"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197381","number":197381,"mergeCommit":{"message":"fix flaky test - counts dashboard views (#197381)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/192564\r\n\r\nIt might take a bit of time for the view count to update. So in the test\r\nwe will try to open the flyout again","sha":"3684dedecb001291f857a1649e721c1e4e6b22e7"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
# Backport This will backport the following commits from `main` to `8.16`: - [fix flaky test - counts dashboard views (#197381)](#197381) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Anton Dosov","email":"anton.dosov@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T13:27:04Z","message":"fix flaky test - counts dashboard views (#197381)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/192564\r\n\r\nIt might take a bit of time for the view count to update. So in the test\r\nwe will try to open the flyout again","sha":"3684dedecb001291f857a1649e721c1e4e6b22e7","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","v8.16.0","backport:version","v8.17.0"],"title":"fix flaky test - counts dashboard views","number":197381,"url":"https://github.com/elastic/kibana/pull/197381","mergeCommit":{"message":"fix flaky test - counts dashboard views (#197381)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/192564\r\n\r\nIt might take a bit of time for the view count to update. So in the test\r\nwe will try to open the flyout again","sha":"3684dedecb001291f857a1649e721c1e4e6b22e7"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197381","number":197381,"mergeCommit":{"message":"fix flaky test - counts dashboard views (#197381)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/192564\r\n\r\nIt might take a bit of time for the view count to update. So in the test\r\nwe will try to open the flyout again","sha":"3684dedecb001291f857a1649e721c1e4e6b22e7"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
## Summary close elastic#192564 I thought I fixed this earlier, but looks like I forget to unskip 😮💨 elastic#197381 This is another attempt (cherry picked from commit 97ee552)
# Backport This will backport the following commits from `main` to `9.0`: - [unskip dashboard_listing (#211742)](#211742) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Anton Dosov","email":"anton.dosov@elastic.co"},"sourceCommit":{"committedDate":"2025-02-19T15:42:26Z","message":"unskip dashboard_listing (#211742)\n\n## Summary\n\nclose https://github.com/elastic/kibana/issues/192564\n\nI thought I fixed this earlier, but looks like I forget to unskip 😮💨\nhttps://github.com//pull/197381\nThis is another attempt","sha":"97ee552d0ffa025c0d7b8032384c4a5b5513a495","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","v9.1.0"],"title":"unskip dashboard_listing","number":211742,"url":"https://github.com/elastic/kibana/pull/211742","mergeCommit":{"message":"unskip dashboard_listing (#211742)\n\n## Summary\n\nclose https://github.com/elastic/kibana/issues/192564\n\nI thought I fixed this earlier, but looks like I forget to unskip 😮💨\nhttps://github.com//pull/197381\nThis is another attempt","sha":"97ee552d0ffa025c0d7b8032384c4a5b5513a495"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211742","number":211742,"mergeCommit":{"message":"unskip dashboard_listing (#211742)\n\n## Summary\n\nclose https://github.com/elastic/kibana/issues/192564\n\nI thought I fixed this earlier, but looks like I forget to unskip 😮💨\nhttps://github.com//pull/197381\nThis is another attempt","sha":"97ee552d0ffa025c0d7b8032384c4a5b5513a495"}}]}] BACKPORT--> Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Summary
fix #192564
It might take a bit of time for the view count to update. So in the test we will try to open the flyout again