Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.16] [Ingest Pipelines] Update copy in Manage processors (#196923) #197196

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

ElenaStoeva
Copy link
Contributor

Backport

This will backport the following commits from main to 8.16:

Questions ?

Please refer to the Backport tool documentation

## Summary

This PR adds some copy changes to the Manage processors pages.

1. Empty prompt
- Width and padding of the prompt is adjusted so that "IP" in the title
starts in the 2nd line
- Description is updated
<img width="800" alt="Screenshot 2024-10-18 at 17 00 53"
src="https://github.com/user-attachments/assets/51aa6cdc-5eb4-4c54-8960-7ee273d82ef5">

2. Add database modal
- Copy in callouts is updated
- The help text of the "Type" field is updated
- The text in the "Database already exists" error callout is updated
<img width="1490" alt="Screenshot 2024-10-21 at 09 34 12"
src="https://github.com/user-attachments/assets/ab3c2e21-4457-435f-a4c3-874c6edcb2ce">
<img width="1498" alt="Screenshot 2024-10-18 at 17 24 43"
src="https://github.com/user-attachments/assets/a0c15f5d-9360-4ee7-806d-2b5b64b6fd2a">

3. Manage processors page
- The title of the page is changed from "GeoIP" to "IP Location"
<img width="800" alt="Screenshot 2024-10-18 at 17 20 01"
src="https://github.com/user-attachments/assets/cde8b070-9664-42df-b71a-723a5356d4a2">

(cherry picked from commit 996eb73)
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ingestPipelines 338 356 +18

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ingestPipelines 392.6KB 404.5KB +11.9KB

@ElenaStoeva
Copy link
Contributor Author

@elasticmachine run docs-build

@ElenaStoeva ElenaStoeva requested review from a team and removed request for kibanamachine October 22, 2024 12:24
@ElenaStoeva ElenaStoeva merged commit 1ad7e5d into elastic:8.16 Oct 22, 2024
25 checks passed
@ElenaStoeva ElenaStoeva deleted the backport/8.16/pr-196923 branch October 23, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants