Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Fix lint error error 'react-use' import is restricted from being used #196381

Closed
wants to merge 1 commit into from
Closed

[fix] Fix lint error error 'react-use' import is restricted from being used #196381

wants to merge 1 commit into from

Conversation

delanni
Copy link
Contributor

@delanni delanni commented Oct 15, 2024 •
edited
Loading

Summary

Merged in #195669 - it passed the lint stage on the PR, but fails in the quick-check and lint stages of on-merge jobs.

The rule was added in #195456 - but the offending PR was last verified several hours before that.

@delanni delanni added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Oct 15, 2024
@delanni delanni requested a review from a team as a code owner October 15, 2024 16:17
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 6031 5917 -114

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.5MB 20.4MB -76.2KB

@jbudz
Copy link
Member

jbudz commented Oct 15, 2024

PR was reverted dbe6d82

@jbudz jbudz closed this Oct 15, 2024
@jbudz jbudz mentioned this pull request Oct 15, 2024
Merged
jbudz added a commit that referenced this pull request Oct 16, 2024
@jbudz @delanni
Reapply "[Security Solution] [Attack discovery] Output chunking / ref…
ad2ac71 
…inement, LangGraph migration, and evaluation improvements (#195669)" (#196440)

#195669 + #196381

This reverts commit dbe6d82.

---------

Co-authored-by: Alex Szabo <alex.szabo@elastic.co>
@delanni delanni deleted the fix-lint-error branch October 16, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephmilovic stephmilovic stephmilovic approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@delanni @elasticmachine @jbudz @stephmilovic